Merged
Conversation
chore: merge master into develop
…utes on elements without a role (#3102) * feat(aria-allowed-attr): report violations for non-global ARIA attributes on elements without a role * fix tests * remove wrong test
* tests: locally host webfonts for is-icon-ligature test * license
* chore: use standards in aria-supported script * fixes
* chore(i18n): updated french translation * integrated proofreading by @audreymaniez * translation improvement after discussion with @audreymaniez
* chore(i18n) Update Korean locale translate - Update translation based on currently develop branch - Change some of existing translation to make it easier to understand Closes issuse: N/A * First correction to reviews * fixed incorrect notaions * fixed missed incorrect notaions - tabindex-1가 -> tabindex=-1이 * fix missed incorrect notations - 반드시 없어야 합니다 -> 존재하지 않아야 합니다 * fix missed incorrect notations - 큰 테이블의 각 비어 있지 않은 데이터 셀이 -> 큰 테이블의 비어 있지 않은 각 데이터 셀이 - 그들이 -> 그것들이 - 의미론 역할 -> 의미론적 역할 - 제공하세요 -> 제공되지 않았습니다 * I reflected the latest changes additionally
* tests: put back autocomplete-valid act tests * chache bust npm * always run latest * Update .circleci/config.yml Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
…es (#3124) * fix(aria-allowed-role): Update allowed roles based on ARIA spec updates * `<b>` now allows any roles * `<nav>` now also allows `menu`, `menubar`, `tablist` * `<svg>` now allows any roles Based on ARIA spec: https://www.w3.org/TR/html-aria/ * fix(aria-allowed-role): Update progress element to not allow any roles Co-authored-by: Timo Gasda <gasda@amazon.com>
This PR sets the axe reporters up so they can run without access to the top-level browsing context. This is needed so that `axe.finishRun()` can be called outside the context of a web page. Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> Co-authored-by: Stephen Mathieson <me@stephenmathieson.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
chore: merge master into develop
…3136) * tests: ensure after and reporter methods can run in isolated context * Update test/integration/full/isolated-env/isolated-env.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * cleanup Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* Added new roles: mark, suggestion, and comment. Closes issue: #3122 * added changes requested * tests: add suggestion no children and amend comment * changes requested * fix comment role * amend comment role Co-authored-by: Gabe Olesen <gabe@Gabes-MacBook-Pro.local>
* Fix nativeSelectValue not picking up selection * Use props instead * Add test for selected prop
* add visible checks and tests * fix typo * enable screenreader on isVisible * add tests * revert playground * add aria-hidden tests * add test and clean up * fix test to pass if aria-invalid is false on hidden element
As per the spec, the context parameter can be passed one of the following: > A `NodeList` such as returned by `document.querySelectorAll`. Source: https://www.deque.com/axe/core-documentation/api-documentation/#context-parameter
* fix(is-visible): do not error if window.Node does not exist * circle * Update test/test-virtual-rules.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
… messageKey (#3181) * tests: check that every check has a message for every return type and messageKey * finalize * fixes * typo
…nding size (#3186) * fix(color-contrast): account for elements that do not fill entire bounding size * not private
* feat: create issue impact documentation * Update doc/issue_impact.md Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update issue_impact.md * Update doc/issue_impact.md Co-authored-by: Stephen Mathieson <me@stephenmathieson.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Stephen Mathieson <me@stephenmathieson.com>
…istbox (#3195) * fix(aria-allowed-children,aria-allowed-parent): allow group role in listbox * fix tests
* fix(color-contrast): properly blend multiple alpha colors * revert shadow * add back shadow color flatten * fix * fix ie11 * type * typo
…fo on footer to only report on top-level rule (#3142) Co-authored-by: Wilco Fiers <wilco.fiers@deque.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* test commit 1 * Revert "test commit 1" This reverts commit 9f996bc. * fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive" Closes issue #2934 * feat(rule): add new rule color-contrast-enhanced (WCAG AAA) Work in progress. * Work in progress. * Work in progress. * Updating shadow-dom test for WCAG AAA contrast. * Rearranging shadow-dom test. * Adding new rule color-contrast-enhanced to code-highlighting test. * adding new 'color-contrast-enhanced' rule to sticky-header test. * Revert "fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive"" This reverts commit 30f0e01. * update rule-descriptions.md * fix whitespace Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * work in progress: splitting tests for contrast and the new contrast-enhanced. * work in progress: tests * work in progress: tests * work in progress: tests * adding separate tests for color-contrast-enhanced. work in progress. * update rule-descriptions.md * add test: test/integration/full/contrast-enhanced/simple.html * remove redundant tests for contrast-enhanced * remove temporary code Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
…ll (#3310) * fix(color-contrast): inconsistency of bgOverlap message based on scroll * it should return null for inline elements with position:absolute * Guessing at how to fix IE
* fix(color-contrast): inconsistency of bgOverlap message based on scroll * feat(commons): deprecate shadowElementsFromPoint
…th no role (#3165) * refactor(checks/navigation): improve `internal-link-present-evaluate` Make `internal-link-present-evaluate` work with virtualNode rather than actualNode. Closes issue #2466 * test commit 1 * test commit 2 * test commit 3 * Revert "Merge branch 'dan-test-branch-1' into develop" This reverts commit 428e015, reversing changes made to 9f996bc. * Revert "test commit 1" This reverts commit 9f996bc. * fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive" Closes issue #2934 * work in progress * work in progress * test commit 1 * Revert "test commit 1" This reverts commit 9f996bc. * fix(rule): allow "tabindex=-1" for rules "aria-text" and "nested-interactive" Closes issue #2934 * work in progress * work in progress * fix whitespace * add new case to test test/checks/keyboard/no-focusable-content.js * change "disabled" test case in test/checks/keyboard/no-focusable-content.js * fix merge problem
* add mix-blend-mode functions * implement some blend functions and tests * fix color-dodge and add test * fix color-burn and add test * clean up * fix hard-light add unit test * add overlay blend-mode and unit test * tests * typo * fix tests * fix flattenColor function * better output for blending integration test * better output for blending integration test * position each group so they don't affect one another * fix blending background white * revert playground * revert playground * fix backgroundColor * fix blending integration tests * add skip for IE11 as blending is not supported * typo Co-authored-by: Steven Lambert <steven.lambert@deque.com>
…3320) * adds role=radio to img alt=foo allowances A `role=radio` was meant to be an allowance for an `img alt=foo`, but it had mistakenly been left out of the spec. ARIA in HTML is fixing this oversight, w3c/html-aria#381, so this PR is to match this added allowance. * odd whitespace fix * Update html-elms.js * add test for img element with valid role=radio * Update aria-allowed-role.json
* fix(custom-elms): Don't error on custom Element.children prop * for index loop
…3335) * ci: always install chromedriver version that matches chrome version * fix windows * only install chromedriver in ci * try nightly * fix * finalize * always use latest chromedriver locally * rename
* chore: update to use `@axe-core/webdriverjs@4.3.2` * fix git npm packages
* fix(axe.d.ts): allow Node for include/exclude object * typo * Update typings/axe-core/axe-core-tests.ts Co-authored-by: Stephen Mathieson <me@stephenmathieson.com> * use Array instead NodeList Co-authored-by: Stephen Mathieson <me@stephenmathieson.com>
…n element without role (#3342) * feat(aria-allowed-attr): report violation for non-global ARIA attrs on element without role * Update lib/checks/aria/aria-allowed-attr.json Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * no role or focusable * ignore button/button_idl.html error * if * Update lib/checks/aria/aria-allowed-attr.json Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
…3350) * fix(color-contrast): check bg on fg contrast for thin text-shadows * fix color-contrast fail7
…e subtree (#3347) * fix(prohibited-attr): always report incomplete if there is text in the subtree Subtree text wasn't computed for elements that are not named from content. To force this, subtreeDescendant: true had to be passed. This PR also significantly improves the messages of the prohibited-attr check, which was the cause of some confusion. * more tests
* fix(skip-link): work with absoulte and relative paths * revert playground * fix ie11 * fix ie11 again * Update lib/commons/dom/is-skip-link.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * finalize * fix * fix ie11 (always) * typo * fix jsdom test * Update lib/commons/dom/is-current-page-link.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * fix issue with usemap * fix ie11 Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
|
Alain Vagner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.