fix: check for hidden elements on aria-errormessage #3156
Merged
Conversation
WilcoFiers
previously requested changes
Sep 20, 2021
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
I feel like adding at least one integration test here would be a good idea.
WilcoFiers
previously requested changes
Sep 23, 2021
test/integration/rules/aria-valid-attr-value/aria-valid-attr-value.html
Outdated
Show resolved
Hide resolved
WilcoFiers
approved these changes
Sep 24, 2021
straker
pushed a commit
that referenced
this pull request
Oct 18, 2021
* add visible checks and tests * fix typo * enable screenreader on isVisible * add tests * revert playground * add aria-hidden tests * add test and clean up * fix test to pass if aria-invalid is false on hidden element
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if hidden elements are present on
aria-errormessageviaisVisible()and add tests.Closes issue: #3149