ci: always install chromedriver version that matches chrome version#3335
Merged
ci: always install chromedriver version that matches chrome version#3335
Conversation
stephenmathieson
requested changes
Jan 6, 2022
Member
|
If this is fixing a CI-only problem, why don't we just have CircleCI run the script (rather than coupling it to |
stephenmathieson
previously requested changes
Jan 6, 2022
Contributor
Author
|
The way I see it this could also be a contributor problem as we are pinning to a version of chromedriver that may not work with the users installed version of chrome. |
Contributor
Author
|
Going to close. Doesn't look like Windows provides a way to get the chrome version through cli. Will look for an alternative solution. |
stephenmathieson
previously approved these changes
Jan 6, 2022
stephenmathieson
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've continually had problems with chromedriver version. When we had it as
@latestwe ran into a problem where CircleCI hadn't updated to the latest Chrome version so the test failed. When we pin we run into problems with always using that version of chromedriver even if the version of Chrome is newer.This pr creates a CircleCI script that will get the current version of Chrome installed and then install the matching chromedriver version. Tested it and it works for both normal test and nightly (after Chrome Beta is installed). This also means we can just pin to the latest version of chromedriver for local dev.