chore: use standards in aria-supported script#3104
Merged
Conversation
Member
stephenmathieson
left a comment
There was a problem hiding this comment.
Any reason to invoke this function twice? Why not do:
const {ariaRoles, ariaAttrs} = axe.utils.getStandards()
WilcoFiers
previously requested changes
Aug 3, 2021
build/tasks/aria-supported.js
Outdated
| const { diff: rolesTable, notes: rolesFootnotes } = getDiff( | ||
| roles, | ||
| axe.commons.aria.lookupTable.role, | ||
| axe.utils.getStandards().ariaRoles, |
Contributor
There was a problem hiding this comment.
I agree with Stephen it's better to invoke getStandards() only once.
stephenmathieson
approved these changes
Aug 3, 2021
straker
added a commit
that referenced
this pull request
Aug 24, 2021
* chore: use standards in aria-supported script * fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently nothing is unsupported in our standards object though, but I tested it with
aria-busyand it worked.Closes issue: #3081