Skip to content

docs: create issue impact documentation#3164

Merged
WilcoFiers merged 4 commits intodevelopfrom
issue-impact-doc
Oct 7, 2021
Merged

docs: create issue impact documentation#3164
WilcoFiers merged 4 commits intodevelopfrom
issue-impact-doc

Conversation

@dylanb
Copy link
Copy Markdown
Contributor

@dylanb dylanb commented Sep 23, 2021

Create public documentation of the issue impact

Closes issue: #2798

@dylanb dylanb requested a review from WilcoFiers September 23, 2021 13:03
@dylanb dylanb requested a review from a team as a code owner September 23, 2021 13:03
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 23, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is adding documentation considered a feature?

Copy link
Copy Markdown
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny edit

Copy link
Copy Markdown
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to do changes requested. Stephen's right, this should be a docs change.

dylanb and others added 2 commits September 27, 2021 13:56
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@dylanb dylanb changed the title feat: create issue impact documentation docs: create issue impact documentation Sep 27, 2021
@dylanb dylanb requested a review from WilcoFiers September 27, 2021 18:00
Copy link
Copy Markdown
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but may want to wait for @WilcoFiers's go ahead.

Co-authored-by: Stephen Mathieson <me@stephenmathieson.com>
@WilcoFiers WilcoFiers merged commit 2bdd953 into develop Oct 7, 2021
@WilcoFiers WilcoFiers deleted the issue-impact-doc branch October 7, 2021 08:10
straker pushed a commit that referenced this pull request Oct 18, 2021
* feat: create issue impact documentation

* Update doc/issue_impact.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update issue_impact.md

* Update doc/issue_impact.md

Co-authored-by: Stephen Mathieson <me@stephenmathieson.com>

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Stephen Mathieson <me@stephenmathieson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants