fix(prohibited-attr): always report incomplete if there is text in the subtree#3347
Merged
WilcoFiers merged 3 commits intodevelopfrom Jan 14, 2022
Merged
fix(prohibited-attr): always report incomplete if there is text in the subtree#3347WilcoFiers merged 3 commits intodevelopfrom
WilcoFiers merged 3 commits intodevelopfrom
Conversation
…e subtree Subtree text wasn't computed for elements that are not named from content. To force this, subtreeDescendant: true had to be passed. This PR also significantly improves the messages of the prohibited-attr check, which was the cause of some confusion.
3c052a3 to
8096c6c
Compare
straker
previously requested changes
Jan 12, 2022
| @@ -9,39 +9,79 @@ describe('aria-prohibited-attr', function() { | |||
| checkContext.reset(); | |||
Contributor
There was a problem hiding this comment.
Need tests for checking when the messageKey is set to noRoleSingular when returned as false and undefined
straker
previously approved these changes
Jan 13, 2022
straker
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtree text wasn't computed for elements that are not named from content. To force this, subtreeDescendant: true had to be passed.
This PR also significantly improves the messages of the prohibited-attr check, which was the cause of some confusion.
Closes issue: #3346