Conversation
…n element without role
Contributor
Author
|
The error from aria practices seems to be a legit issue on aria practices? The violation reported on the This is the page: https://www.w3.org/TR/wai-aria-practices-1.2/examples/button/button_idl.html And the error: {
"any": [
{
"id": "aria-allowed-attr",
"data": [
"aria-pressed=\"false\""
],
"relatedNodes": [],
"impact": "critical",
"message": "ARIA attribute is not allowed: aria-pressed=\"false\""
}
],
"all": [],
"none": [],
"impact": "critical",
"html": "<a tabindex=\"0\" id=\"toggle\" aria-pressed=\"false\">\n Mute\n <svg aria-hidden=\"true\" focusable=\"false\">\n <use xlink:href=\"#icon-sound\"></use>\n </svg>\n </a>",
"target": [
"#toggle"
],
"failureSummary": "Fix any of the following:\n ARIA attribute is not allowed: aria-pressed=\"false\""
} |
WilcoFiers
previously requested changes
Jan 11, 2022
WilcoFiers
reviewed
Jan 11, 2022
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
reviewed
Jan 11, 2022
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reintroduces the change to report violations on elements without a role for non-global ARIA attrs, which was reverted when we accidentally released it.
This also introduces a fix for custom elements where we will report Needs Review for any custom element that uses a non-global ARIA attribute (rather than a failure).
Closes issue: #3241