Skip to content

fix: remove optional crypto dependency (webpack compatibility)#3358

Merged
straker merged 1 commit intodevelopfrom
crypto
Jan 21, 2022
Merged

fix: remove optional crypto dependency (webpack compatibility)#3358
straker merged 1 commit intodevelopfrom
crypto

Conversation

@straker
Copy link
Copy Markdown
Contributor

@straker straker commented Jan 20, 2022

With webpack v5, it looks like it will now give constant warnings for axe-core crypto dependency unless the user adds resolve.fallback: { 'crypto': false } to their code. Removing the dependency as it was just suppose to be optional if the code was running in node.

@straker straker requested a review from a team as a code owner January 20, 2022 21:58
@WilcoFiers WilcoFiers changed the title feat: remove optional crypto dependency fix: remove optional crypto dependency (webpack compatibility) Jan 21, 2022
@straker straker merged commit aa9d095 into develop Jan 21, 2022
@straker straker deleted the crypto branch January 21, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants