refactor(checks/navigation): improve internal-link-present-evaluate#3128
Merged
straker merged 1 commit intodequelabs:developfrom Aug 31, 2021
Merged
refactor(checks/navigation): improve internal-link-present-evaluate#3128straker merged 1 commit intodequelabs:developfrom
internal-link-present-evaluate#3128straker merged 1 commit intodequelabs:developfrom
Conversation
Make `internal-link-present-evaluate` work with virtualNode rather than actualNode. Closes issue dequelabs#2466
|
|
Contributor
|
Sorry I missed this pr. I'll get this looked at today. |
straker
approved these changes
Aug 30, 2021
Contributor
straker
left a comment
There was a problem hiding this comment.
Thanks for the pr! If you haven't already, could you sign the CLA license?
Contributor
Author
|
Sure thing - I just signed the CLA license. |
Contributor
|
Reviewed for security |
Contributor
Author
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
internal-link-present-evaluatework with virtualNode rather than actualNode.Closes issue #2466