fix(aria-allowed-role): Update allowed roles based on ARIA spec updates#3124
Merged
fix(aria-allowed-role): Update allowed roles based on ARIA spec updates#3124
Conversation
* `<b>` now allows any roles * `<nav>` now also allows `menu`, `menubar`, `tablist` * `<svg>` now allows any roles Based on ARIA spec: https://www.w3.org/TR/html-aria/
…xe-core into timogasda-fix-allow-aria-roles
WilcoFiers
approved these changes
Aug 18, 2021
straker
added a commit
that referenced
this pull request
Aug 24, 2021
…es (#3124) * fix(aria-allowed-role): Update allowed roles based on ARIA spec updates * `<b>` now allows any roles * `<nav>` now also allows `menu`, `menubar`, `tablist` * `<svg>` now allows any roles Based on ARIA spec: https://www.w3.org/TR/html-aria/ * fix(aria-allowed-role): Update progress element to not allow any roles Co-authored-by: Timo Gasda <gasda@amazon.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #3117 due to CircleCI problem of not running tests for outside contributors.
Closes issue: #3082