fix(nativeSelectValue): update selected value on change#3154
fix(nativeSelectValue): update selected value on change#3154straker merged 3 commits intodequelabs:developfrom
Conversation
There was a problem hiding this comment.
Awesome. That looks better. One last thing, could you add a test to https://github.com/dequelabs/axe-core/blob/develop/test/core/base/virtual-node/virtual-node.js? I know we don't have tests for the node specific props (multiple, nodeValue, value, etc.), but I think that might be a failing on our part.
The test can be as simple "node with selected property is reflected in props" or something, just so we don't delete it one day without knowing.
| }); | ||
| }); | ||
|
|
||
| describe('props', function() { |
There was a problem hiding this comment.
Did you mean to add these tests? They look like copy/paste from the previous describe('attr')
There was a problem hiding this comment.
Oops! Deleted!
88d8ba0 to
2ce8af8
Compare
straker
left a comment
There was a problem hiding this comment.
Great work! Thanks for fixing this.
|
Reviewed for security |
nativeSelectValue not picking up selection* Fix nativeSelectValue not picking up selection * Use props instead * Add test for selected prop
nativeSelectValuedoesn't return the selected value after manual selection. This PR fixes that by using theselectedon<option>to get the up-to-date value.