tests: check that every check has a message for every return type and messageKey#3181
Merged
tests: check that every check has a message for every return type and messageKey#3181
Conversation
WilcoFiers
approved these changes
Oct 5, 2021
straker
added a commit
that referenced
this pull request
Oct 18, 2021
… messageKey (#3181) * tests: check that every check has a message for every return type and messageKey * finalize * fixes * typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will check that every time a checks unit test is run, it verifies that there exists a message for the return type, also taking into account how
nonechecks use the opposite messages (e.g. a result oftruewill use afailmessage). It will also verify that if the check has adata.messageKeyproperty, that a specific message exists in the messages for that key.Doing this revealed that we should combine the
non-empty-if-presentandnon-empty-valuechecks as the fail state for what it's looking for (the state of thevalueattribute) produces a double message about the attribute:Also made sure no
passresult had a message key it didn't use in color-contrast (which seems to have run prettier on the file so that's why all the changes)Closes issue: #3173