Merged
Conversation
* Update fee card designs to show savings and MM fee css touch up More semantic html and remove unnecessary container wrapper Update message for case when there are no savings, in new swaps fee card designs Improve display of tilde in savings designs * Ensure terms of service is shown when insufficient eth warning is shown on view-quote screen * Logic simplification in fee-card.js * Better center info tooltip icons in fee-card * Add comment about use of \!important in fee card css * Use container class property on info tooltip in fee card * Remove function call that was made redundant with 980b140 but not removed during rebase
Show send text upon hover in main asset list
This reverts commit f30d261. The custom HD path option was found to be unsafe to use, because the displayed list of accounts would differ depending on which application was open on the Ledger device. Essentially Ledger was accepting invalid inputs, and returning junk responses. This was too dangerous to ship, as it could leave users with an account that they can't reliably recover. If we don't know how the derivation is happening, then allowing this import puts our users at risk of losing funds. We can re-introduce this functionality after adding validation to ensure that we only allow inputs that are handled correctly by Ledger.
`PropTypes.oneOf` was used accidentally instead of `PropTypes.oneOfType`. `oneOf` expects literal values, not types.
`PropTypes.function` was used accidentally instead of `PropType.func`
Make editable action item a button, autofocus input contents
Provide alternative text for images where appropriate
Properly detect U2F errors in hardware wallet
Prevent jump when hovering over asset list items
* Consolidate notification UI openers * Update tests
Remove all CoinSwitch references and functionality, and bump Wyre to top spot on Deposit screen unless user on test network
* Move add contact button in fullscreen/expanded view. Fixes #9868 Move the add contact button that is overlapping (x)/close setting icon lower, on the same line as Contacts in fullscreen/expanded view.
* origin/develop: Move add contact button in fullscreen/expanded view lower. (#9883) Remove CoinSwitch from Deposit screen(#9869) Consolidate notification UI openers (#9885) Prevent jump when hovering over asset list items @metamask/controllers@4.2.0 (#9849) Properly detect U2F errors in hardware wallet Fix malformed PropType declaraton (#9876) Fix broken LoadingScreen PropType declaration (#9877) Revert "Add custom hd path option (#9367)" (#9875) Update fee card designs to show savings and MM fee (#9629) Make editable actoin item a button, autofocus input contents Provide alternative text for images where appropriate
Sync `master` with `develop`
The `sentry:publish` script now exits with an exit code of `1` upon failure, indicating that something went wrong. Previously it would exit with a code of `0`, indicating to CI that everything worked correctly. The script will now also exit early if the authentication check fails.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* Fix minor issues with web3 metrics * Log error, use try/catch
The `matomo` option passed to the send metrics function is invalid. The intent was to set the `matomoEvent` option, but instead of rectifying that, we've decide to keep sending this event to the production Segment project for now. The invalid option has been removed.
* Add token verification message to swaps build quote screen * Adds description for locale * Use <a> tag for etherscan link * Remove unnecessary span * Update ui/app/pages/swaps/build-quote/build-quote.js Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Bumps [@metamask/eth-token-tracker](https://github.com/MetaMask/eth-token-tracker) from 3.0.1 to 3.1.0. - [Release notes](https://github.com/MetaMask/eth-token-tracker/releases) - [Changelog](https://github.com/MetaMask/eth-token-tracker/blob/master/CHANGELOG.md) - [Commits](https://github.com/MetaMask/eth-token-tracker/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Author
Builds ready [406ace9]
Page Load Metrics (362 ± 51 ms)
|
944460e to
71d5e2d
Compare
Collaborator
Author
Builds ready [71d5e2d]
Page Load Metrics (414 ± 60 ms)
|
71d5e2d to
8b3bc1f
Compare
Collaborator
Author
Builds ready [8b3bc1f]
Page Load Metrics (489 ± 78 ms)
|
Collaborator
Author
Builds ready [d913d92]
Page Load Metrics (493 ± 112 ms)
|
kumavis
previously approved these changes
Nov 19, 2020
This fixes a PropType error when using non-custom slippage, and it fixes a type inconsistency when custom slippage is used. Previously, `slippage` was being converted explicitly to a `Number` as it was passed into `BuildQuote`, but not as it was passed into `AwaitingSwap`. Also the PropType was set as `string`, despite the fact that it's a number in most cases, and is used for math. The PropType has been changed to `number`, and the selective casting to `Number` has been removed. Instead, the `maxSlippage` value is cast to a `Number` as it's being selected, so that the type is always consistent.
* Include error string from ledger errors * Type check error message Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* Validate sendToken address when component updates On a reproduction of trying to get the error message it seems that if an token address is provided in the address form with ETH selected then changing to a token address, the error message won't show. This will validate the sendtoken address on prop change to properly update the warning message. * Update test to include second doesAmountErrorRequireUpdate call when state is updated and component is updated
* Override font-weight from Paragraph and set to 900 * Fix checkmark font-weight on swaps gas button selector
327d16a to
3ea6f7f
Compare
Gudahtt
reviewed
Nov 19, 2020
CHANGELOG.md
Outdated
Member
There was a problem hiding this comment.
Something like this might be a better description:
Fix display of Ledger connection error
Collaborator
Author
Builds ready [3ea6f7f]
Page Load Metrics (384 ± 39 ms)
|
* Update changelog for v8.1.5 * Update CHANGELOG.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
3ea6f7f to
fbb46c4
Compare
tmashuang
approved these changes
Nov 19, 2020
Collaborator
Author
Builds ready [fbb46c4]
Page Load Metrics (358 ± 45 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 🚀