Skip to content

Override font-weight from Paragraph and set to 900#9918

Merged
tmashuang merged 3 commits intodevelopfrom
missing-token-external-link-icon
Nov 19, 2020
Merged

Override font-weight from Paragraph and set to 900#9918
tmashuang merged 3 commits intodevelopfrom
missing-token-external-link-icon

Conversation

@tmashuang
Copy link
Copy Markdown
Contributor

@tmashuang tmashuang commented Nov 19, 2020

Fixes: Missing icon next to View on Etherscan on an individual token

Before
After

Addition: Fixes: #9762

Before
After

@tmashuang tmashuang requested a review from a team as a code owner November 19, 2020 19:13
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brad-decker
Copy link
Copy Markdown
Contributor

Oops. Thanks, @tmashuang -- In other areas where we are using the trash icon it is also 900, so this LGTM

brad-decker
brad-decker previously approved these changes Nov 19, 2020
@brad-decker brad-decker self-assigned this Nov 19, 2020
Copy link
Copy Markdown
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [43621b9]
Page Load Metrics (342 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30743894
domContentLoaded2586013409244
load2596033429244
domInteractive2586013409244

@tmashuang tmashuang merged commit 35af9ea into develop Nov 19, 2020
@tmashuang tmashuang deleted the missing-token-external-link-icon branch November 19, 2020 20:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Odd Character Displaying in Gas Popup

4 participants