Skip to content

show failed token balance updates#9896

Merged
brad-decker merged 1 commit intodevelopfrom
fix-9057
Nov 18, 2020
Merged

show failed token balance updates#9896
brad-decker merged 1 commit intodevelopfrom
fix-9057

Conversation

@brad-decker
Copy link
Copy Markdown
Contributor

@brad-decker brad-decker commented Nov 17, 2020

Fixes: #9057

requires the future release of eth-token-tracker after MetaMask/eth-token-tracker#53 lands.

steps to test:

  1. clone eth-token-tracker and checkout allow-updating-failed-tokens branch.
  2. run yarn install
  3. run yarn build
  4. run yarn link
  5. switch to metamask-extension repo
  6. run yarn link @metamask/eth-token-tracker
  7. run yarn start
  8. load the assets screen and follow the steps in Custom tokens not shown if balance update fails #9057
Before (no tokens show up due to error) Before: No tokens show up due to error in SNX
After (all tokens show up, error on SNX) After: All tokens show up, error shown only on SNX

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [e6c1330]
Page Load Metrics (369 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31463642
domContentLoaded26461636810651
load26561836910651
domInteractive26361636710651

@brad-decker brad-decker marked this pull request as ready for review November 17, 2020 22:25
@brad-decker brad-decker requested a review from a team as a code owner November 17, 2020 22:25
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [6926f91]
Page Load Metrics (410 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35108562411
domContentLoaded2996524099144
load3016534109144
domInteractive2996524089144

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [932cb74]
Page Load Metrics (470 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded273105746820297
load274105847020397
domInteractive273105646820297

Copy link
Copy Markdown
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 5be20d1 into develop Nov 18, 2020
@brad-decker brad-decker deleted the fix-9057 branch November 18, 2020 22:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom tokens not shown if balance update fails

3 participants