Track a new schema event when adding a token#9810
Merged
brad-decker merged 6 commits intodevelopfrom Nov 17, 2020
Merged
Conversation
Collaborator
Builds ready [622ad0d]
Page Load Metrics (349 ± 52 ms)
|
Contributor
|
Not a blocker but do we want a |
Contributor
Author
Gudahtt
reviewed
Nov 6, 2020
Gudahtt
reviewed
Nov 6, 2020
Gudahtt
reviewed
Nov 6, 2020
Collaborator
Builds ready [8e678cf]
Page Load Metrics (397 ± 66 ms)
|
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
8e678cf to
6e8a36e
Compare
Collaborator
Builds ready [6e8a36e]
Page Load Metrics (421 ± 59 ms)
|
Gudahtt
requested changes
Nov 16, 2020
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Found one issue, but everything looks good aside from that!
Gudahtt
reviewed
Nov 16, 2020
Collaborator
Builds ready [a0fe3e9]
Page Load Metrics (399 ± 65 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
The new schema has an event for 'Token Added', the intent of which is to surface popular tokens that are being added in spikes. This would help to inform support of the potential influx of issues as well as swaps for adding support for new token pairs.