track sensitiveProperties in a duplicate event.#9807
Merged
brad-decker merged 1 commit intodevelopfrom Nov 10, 2020
Merged
Conversation
Contributor
Author
Member
|
This seems like a good idea! I hope we're not to cavalier about what we're collecting with these "sensitive properties", as we still can't include anything that is identifiable on its own. But having this pattern built-in seems convenient to me - and helps explain to the reader what's happening, whereas the old pattern of two events always looks strange at first glance. |
4330f90 to
a7feec6
Compare
Collaborator
Builds ready [a7feec6]
Page Load Metrics (466 ± 51 ms)
|
Gudahtt
reviewed
Nov 9, 2020
Gudahtt
reviewed
Nov 9, 2020
ui/app/pages/swaps/loading-swaps-quotes/loading-swaps-quotes.js
Outdated
Show resolved
Hide resolved
a7feec6 to
b492ea2
Compare
Collaborator
Builds ready [b492ea2]
Page Load Metrics (510 ± 62 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
anonymousIdone with the user's realMetaMetricsID.Details:
by providing an object with
sensitiveProperties, those properties will be sent in a separate event withanonymousIdset instead of the user'sMetaMetricsID. If bothsensitivePropertiesandpropertiesare provided then the anonymous event will include both, and the identifiable event will include onlyproperties.