Merged
Conversation
This fixes a PropType error when using non-custom slippage, and it fixes a type inconsistency when custom slippage is used. Previously, `slippage` was being converted explicitly to a `Number` as it was passed into `BuildQuote`, but not as it was passed into `AwaitingSwap`. Also the PropType was set as `string`, despite the fact that it's a number in most cases, and is used for math. The PropType has been changed to `number`, and the selective casting to `Number` has been removed. Instead, the `maxSlippage` value is cast to a `Number` as it's being selected, so that the type is always consistent.
Collaborator
Builds ready [9d114c9]
Page Load Metrics (361 ± 38 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a PropType error when using non-custom slippage, and it fixes a type inconsistency when custom slippage is used.
Previously,
slippagewas being converted explicitly to aNumberas it was passed intoBuildQuote, but not as it was passed intoAwaitingSwap. Also the PropType was set asstring, despite the fact that it's a number in most cases, and is used for math.The PropType has been changed to
number, and the selective casting toNumberhas been removed. Instead, themaxSlippagevalue is cast to aNumberas it's being selected, so that the type is always consistent.