Validate sendToken address when component updates#9907
Merged
Conversation
On a reproduction of trying to get the error message it seems that if an token address is provided in the address form with ETH selected then changing to a token address, the error message won't show. This will validate the sendtoken address on prop change to properly update the warning message.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…state is updated and component is updated
Collaborator
Builds ready [5043697]
Page Load Metrics (396 ± 67 ms)
|
Member
I agree - "Known contract address" could still be pretty confusing for a lot of users. That doesn't seem great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a reproduction of trying to get the
Known contract addresserror message it seems that if an token address is set as the recipient along with asset ETH selected then changing the asset to a token address, the error message won't show.This will validate the sendtoken address on prop change to properly update the warning message.
Manual testing steps:
0x0F5D2fB29fb7d3CFeE444a200298f468908cC942 (MANA)Known contract addressshould not show.Additional feedback:
Is the
Known contract addresserror sufficient description? Maybe it should be clearer, likeWarning: sending token to token address?