Conversation
Gudahtt
reviewed
Nov 17, 2020
Gudahtt
requested changes
Nov 17, 2020
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Could you switch to using try ... catch instead? I'd rather we never use .catch and .then at all going forward, because it prevents async stack traces from working correctly.
Collaborator
Builds ready [b753e6b]
Page Load Metrics (357 ± 45 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following issues with the updated web3 metrics:
ethereum.requestin logging callsshouldLogUsageif block