Skip to content

Removes the view on etherscan link on the assets page#9909

Merged
danjm merged 1 commit intodevelopfrom
remove-asset-etherscan-link
Nov 19, 2020
Merged

Removes the view on etherscan link on the assets page#9909
danjm merged 1 commit intodevelopfrom
remove-asset-etherscan-link

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Nov 18, 2020

Fixes: #9898

@danjm danjm requested a review from a team as a code owner November 18, 2020 21:04
@danjm danjm requested a review from rekmarks November 18, 2020 21:04
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [53232df]
Page Load Metrics (405 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint319045168
domContentLoaded2825734038641
load2835744058541
domInteractive2815724038541

@danjm danjm force-pushed the remove-asset-etherscan-link branch from 53232df to fdc86e2 Compare November 18, 2020 21:40
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [fdc86e2]
Page Load Metrics (437 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32119512311
domContentLoaded26484843514972
load26585043714972
domInteractive26484843514972

@danjm danjm merged commit 179e795 into develop Nov 19, 2020
@danjm danjm deleted the remove-asset-etherscan-link branch November 19, 2020 01:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide the Etherscan "token link" until we seriously prevent users from sending to token addresses.

3 participants