Skip to content

Remove invalid matomo metric event option#9897

Merged
Gudahtt merged 1 commit intodevelopfrom
remove-invalid-matomo-flag
Nov 17, 2020
Merged

Remove invalid matomo metric event option#9897
Gudahtt merged 1 commit intodevelopfrom
remove-invalid-matomo-flag

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Nov 17, 2020

The matomo option passed to the send metrics function is invalid. The intent was to set the matomoEvent option, but instead of rectifying that, we've decide to keep sending this event to the production Segment project for now. The invalid option has been removed.

The `matomo` option passed to the send metrics function is invalid. The
intent was to set the `matomoEvent` option, but instead of rectifying
that, we've decide to keep sending this event to the production Segment
project for now. The invalid option has been removed.
@Gudahtt Gudahtt requested a review from a team as a code owner November 17, 2020 18:43
@Gudahtt Gudahtt requested a review from danjm November 17, 2020 18:43
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [b22b1cc]
Page Load Metrics (421 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint319450199
domContentLoaded27874741913766
load27974842113766
domInteractive27874741913766

@Gudahtt Gudahtt merged commit 31a3541 into develop Nov 17, 2020
@Gudahtt Gudahtt deleted the remove-invalid-matomo-flag branch November 17, 2020 19:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants