Include error string from ledger errors#9911
Conversation
Also remove the componentMount to check hardware status. This would constantly check the status of the hardware wallet upon mounting, even after the wallet is unplugged.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [60d3d98]
Page Load Metrics (357 ± 34 ms)
|
|
|
| // eslint-disable-next-line react/jsx-key | ||
| <a | ||
| href="https://metamask.zendesk.com/hc/en-us/articles/360020394612-How-to-connect-a-Trezor-or-Ledger-Hardware-Wallet" | ||
| key="hardware-connection-guide" |
There was a problem hiding this comment.
I believe this fixes the react warning for a unique key.
This was added in #4851. I'm guessing that the purpose of checking whether the device is locked upon mount was to know whether to call As janky as this is, it might be better to leave it alone until we're ready to delete this "temporary alert" altogether, or verify it still works as intended. Certainly seems better to leave it for another PR. |
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Builds ready [10064ce]
Page Load Metrics (353 ± 49 ms)
|
Also remove the componentMount to check hardware status. This would constantly check the status of the hardware wallet upon mounting, even after the wallet is unplugged.Manual testing steps on Win10/Firefox
2.1 Win10 users will need to cancel/close(x) the Windows Security window for usb.
TypeError: t is undefinedwill log to the console, and the error message won't render,metamask-extension/ui/app/pages/create-account/connect-hardware/index.js
Lines 200 to 220 in 60d3d98