Add token verification message to swaps build quote screen#9891
Merged
Add token verification message to swaps build quote screen#9891
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
reviewed
Nov 16, 2020
Gudahtt
reviewed
Nov 16, 2020
Collaborator
Builds ready [c8d7714]
Page Load Metrics (451 ± 60 ms)
|
Contributor
Author
|
@Gudahtt your two comments are addressed in the two most recent commits |
Collaborator
Builds ready [631fd07]
Page Load Metrics (410 ± 58 ms)
|
Gudahtt
reviewed
Nov 17, 2020
| {selectedToToken?.address && | ||
| selectedToToken?.address !== ETH_SWAPS_TOKEN_OBJECT.address && ( | ||
| <div className="build-quote__token-message"> | ||
| <span> |
Member
There was a problem hiding this comment.
What is the purpose of this span?
Contributor
Author
There was a problem hiding this comment.
Nothing 😅 It has been removed
Gudahtt
reviewed
Nov 17, 2020
Collaborator
Builds ready [a0565e1]
Page Load Metrics (319 ± 44 ms)
|
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Collaborator
Builds ready [9164df2]
Page Load Metrics (355 ± 50 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #9873
The user will now see a message below the token 'to' field that links them to etherscan where they can verify that the token they selected is the one they indeed wish to swap.