Skip to content

Make editable action item a button, autofocus input contents#9855

Merged
darkwing merged 1 commit intoMetaMask:developfrom
darkwing:edit-account-focus
Nov 13, 2020
Merged

Make editable action item a button, autofocus input contents#9855
darkwing merged 1 commit intoMetaMask:developfrom
darkwing:edit-account-focus

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

Explanation:

This PR converts the edit icon to a button so that it's focusable and that the account name is focused when clicked.

AccountEditFOcus

@darkwing darkwing requested a review from a team as a code owner November 11, 2020 18:02
@darkwing darkwing requested a review from danjm November 11, 2020 18:02
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkwing darkwing merged commit d78e6dc into MetaMask:develop Nov 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants