Conversation
This reverts commit f30d261. The custom HD path option was found to be unsafe to use, because the displayed list of accounts would differ depending on which application was open on the Ledger device. Essentially Ledger was accepting invalid inputs, and returning junk responses. This was too dangerous to ship, as it could leave users with an account that they can't reliably recover. If we don't know how the derivation is happening, then allowing this import puts our users at risk of losing funds. We can re-introduce this functionality after adding validation to ensure that we only allow inputs that are handled correctly by Ledger.
`PropTypes.oneOf` was used accidentally instead of `PropTypes.oneOfType`. `oneOf` expects literal values, not types.
`PropTypes.function` was used accidentally instead of `PropType.func`
Changes that aren't user-facing have been omitted.
A few new user-facing features have been pulled into the release, and the custom HD path support has been reverted.
The hardware wallet error handling improvements have been added to the release.
Version v8.1.4 RC
* origin/develop: Move add contact button in fullscreen/expanded view lower. (#9883) Remove CoinSwitch from Deposit screen(#9869) Consolidate notification UI openers (#9885) Prevent jump when hovering over asset list items @metamask/controllers@4.2.0 (#9849) Properly detect U2F errors in hardware wallet Fix malformed PropType declaraton (#9876) Fix broken LoadingScreen PropType declaration (#9877) Revert "Add custom hd path option (#9367)" (#9875) Update fee card designs to show savings and MM fee (#9629) Make editable actoin item a button, autofocus input contents Provide alternative text for images where appropriate
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
rekmarks
approved these changes
Nov 16, 2020
Member
rekmarks
left a comment
There was a problem hiding this comment.
The date on the changelog is wrong, but I don't know that we care
| ## Current Develop Branch | ||
| - [#9612](https://github.com/MetaMask/metamask-extension/pull/9612): Update main-quote-summary designs/styles | ||
|
|
||
| ## 8.1.4 Tue Nov 10 2020 |
Member
Author
There was a problem hiding this comment.
All of the dates in this changelog are wrong 😅 The date is generated when the changelog is updated.
I think we should update the changelog script to omit a date altogether. Then maybe add it manually in this sync PR. I'll leave that for another day - the real dates can be applied retroactively by looking at the GitHub releases at least.
Member
Author
There was a problem hiding this comment.
Oh and once we automate our release process, this step can be automated as well.
Collaborator
Builds ready [f9613b2]
Page Load Metrics (379 ± 38 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings
developup to date with thev8.1.4release.This PR also includes a revert of the revert of the new main quote designs (i.e. they have been restored).