Skip to content

chore: Upgrade @metamask/controller-utils to v8.0.1#22500

Merged
Gudahtt merged 9 commits intodevelopfrom
upgrade-controller-utils-to-v8
Jan 24, 2024
Merged

chore: Upgrade @metamask/controller-utils to v8.0.1#22500
Gudahtt merged 9 commits intodevelopfrom
upgrade-controller-utils-to-v8

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 11, 2024

Description

The package @metamask/controller-utils has been upgraded to v8.0.1. The breaking changes did not affect any of the imports used by the extension.

See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/controller-utils/CHANGELOG.md#801

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 11, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@Gudahtt Gudahtt added the team-extension-platform Extension Platform team label Jan 11, 2024
@Gudahtt Gudahtt marked this pull request as ready for review January 11, 2024 21:35
@Gudahtt Gudahtt requested review from a team as code owners January 11, 2024 21:35
@Gudahtt Gudahtt force-pushed the upgrade-controller-utils-to-v8 branch from d8a24a3 to bc99c94 Compare January 11, 2024 23:12
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [bc99c94]
Page Load Metrics (1348 ± 152 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1013081916431
domContentLoaded11213847636
load85318741348316152
domInteractive11213847636
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 62.67 KiB (1.90%)
  • ui: 0 Bytes (0.00%)
  • common: -32 KiB (-0.62%)

@Gudahtt Gudahtt force-pushed the upgrade-controller-utils-to-v8 branch from bc99c94 to 65fa0d5 Compare January 12, 2024 15:31
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 12, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd7ed3c) 68.16% compared to head (4c4f466) 68.13%.

❗ Current head 4c4f466 differs from pull request most recent head 4f491e0. Consider uploading reports for the commit 4f491e0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #22500      +/-   ##
===========================================
- Coverage    68.16%   68.13%   -0.04%     
===========================================
  Files         1087     1087              
  Lines        42691    42665      -26     
  Branches     11358    11349       -9     
===========================================
- Hits         29100    29066      -34     
- Misses       13591    13599       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [c608955]
Page Load Metrics (1473 ± 129 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint973201755828
domContentLoaded10173464421
load87617731473270129
domInteractive10173464421
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 62.67 KiB (1.90%)
  • ui: 0 Bytes (0.00%)
  • common: -32 KiB (-0.62%)

@Gudahtt Gudahtt force-pushed the upgrade-controller-utils-to-v8 branch from c608955 to 1087ca7 Compare January 12, 2024 17:41
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1087ca7]
Page Load Metrics (1182 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint852571325225
domContentLoaded8174385526
load8301596118217283
domInteractive8174385526

@Gudahtt Gudahtt force-pushed the upgrade-controller-utils-to-v8 branch from 1087ca7 to 93c3608 Compare January 12, 2024 20:47
@legobeat legobeat force-pushed the upgrade-controller-utils-to-v8 branch from 93c3608 to 5382b05 Compare January 15, 2024 11:06
legobeat
legobeat previously approved these changes Jan 15, 2024
@Gudahtt Gudahtt force-pushed the upgrade-controller-utils-to-v8 branch from 5382b05 to 2aff767 Compare January 15, 2024 20:54
@Gudahtt Gudahtt force-pushed the upgrade-controller-utils-to-v8 branch from 2aff767 to 5efab3e Compare January 16, 2024 17:00
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 16, 2024

Rebased to resolve conflicts

@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 16, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@Gudahtt Gudahtt force-pushed the upgrade-controller-utils-to-v8 branch from 5efab3e to 6c2fa97 Compare January 16, 2024 17:15
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 16, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@Gudahtt Gudahtt force-pushed the upgrade-controller-utils-to-v8 branch 2 times, most recently from e655e42 to 541c5db Compare January 17, 2024 21:48
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 17, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

Gudahtt and others added 3 commits January 18, 2024 10:02
The package `@metamask/controller-utils` has been upgraded to `v8.0.1`.
The breaking changes did not affect any of the imports used by the
extension.

See here for the changelog: https://github.com/MetaMask/core/blob/main/packages/controller-utils/CHANGELOG.md#801
@Gudahtt Gudahtt force-pushed the upgrade-controller-utils-to-v8 branch from 359e79e to 67a37fe Compare January 18, 2024 13:32
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [f3d5ac8]
Page Load Metrics (1676 ± 188 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint993222066531
domContentLoaded11201665828
load103722041676391188
domInteractive11201665828
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -17.65 KiB (-0.52%)
  • ui: 0 Bytes (0.00%)
  • common: -63.24 KiB (-1.23%)

legobeat
legobeat previously approved these changes Jan 19, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 19, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/apg-js@4.3.0

View full report↗︎

…-utils-to-v8

* origin/develop: (28 commits)
  Fix "Snap account signatures" flaky tests (#22614)
  Part of #20163 for file ui\components\app\modals\eth-sign-modal\eth-sign-modal.js (#20599)
  deps: @metamask/eth-token-tracker@^4.0.0->^7.0.1 (#22352)
  Part of #17670 for file ui\pages\onboarding-flow\create-password\create-password.js (#20795)
  Part of #20163 for file ui\components\app\create-new-vault\create-new-vault.js (#20535)
  Replaced ActionableMessage and Deprecated Button (#20443)
  Fixing Broken TokenAllowance Story (#20422)
  Move native token value below Fiat within Token list (#22601)
  deps: eth-method-registry@^2.0.0->^3.0.0 (#22351)
  fix: Fix phishing warning page unresponsiveness (#22645)
  replace hex values with design tokens (#22585)
  Adding metametrics to primary currency setting (#22481)
  updated e2e for account unpinning (#22632)
  Added wait for the overlay spinner before the click was performed (#22622)
  fix:feat: support Blockaid What's New Dark Theme and add useTheme util (#22613)
  test: fix flaky test PPOM Blockaid Alert for ERC20 Approve by adding missing mocks (#22617)
  fix(14311): display explorer domain instead of hardcoded Etherscan explorer name (#22483)
  replace rgba static part 2 (#22580)
  docs: add schema validation for manifest json files (#22517)
  Fix #22571 - Prevent flakiness in Import test (#22612)
  ...
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 24, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [4c4f466]
Page Load Metrics (794 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint9413411294
domContentLoaded10441884
load6758877945225
domInteractive10441884
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -14.65 KiB (-0.44%)
  • ui: 0 Bytes (0.00%)
  • common: -65.93 KiB (-1.29%)

Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [4f491e0]
Page Load Metrics (812 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint951731192110
domContentLoaded96020105
load71610198128139
domInteractive96020105
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -14.65 KiB (-0.44%)
  • ui: 0 Bytes (0.00%)
  • common: -65.93 KiB (-1.29%)

Copy link
Copy Markdown
Contributor

@garrettbear garrettbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit 3996f50 into develop Jan 24, 2024
@Gudahtt Gudahtt deleted the upgrade-controller-utils-to-v8 branch January 24, 2024 19:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.10.0 Issue or pull request that will be included in release 11.10.0 team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants