Skip to content

replace rgba static part 2#22580

Merged
garrettbear merged 1 commit intodevelopfrom
feat/replace-rgba-static-part-2
Jan 22, 2024
Merged

replace rgba static part 2#22580
garrettbear merged 1 commit intodevelopfrom
feat/replace-rgba-static-part-2

Conversation

@garrettbear
Copy link
Copy Markdown
Contributor

Description

Part 2 Replace static RGBA values to a token from design-tokens that best matches. If unavailable, a temporary file has been set up for any new tokens needed but not yet provided by the design-tokens package.

Related issues

Fixes: #22361

Manual testing steps

  1. Run locally
  2. Compare local storybook to production storybook on the components color change
  3. Be sure to test light and dark mode

Screenshots/Recordings

See code for before and after photos or video of each change

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@garrettbear garrettbear added the team-design-system All issues relating to design system in Extension label Jan 17, 2024
@garrettbear garrettbear requested a review from a team as a code owner January 17, 2024 21:38
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

&__card {
margin: 16px;
box-shadow: 0 4px 16px rgba(0, 0, 0, 0.15);
box-shadow: var(--shadow-size-md) var(--color-shadow-default);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight change in dark mode (improvement)

Before & After

Screen.Recording.2024-01-11.at.2.46.29.PM.mov

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [36929df]
Page Load Metrics (1324 ± 126 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint963011887134
domContentLoaded11215758139
load95118021324263126
domInteractive11215758139
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@garrettbear garrettbear merged commit d720bb9 into develop Jan 22, 2024
@garrettbear garrettbear deleted the feat/replace-rgba-static-part-2 branch January 22, 2024 20:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.10.0 Issue or pull request that will be included in release 11.10.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EXT] Replace static rgba() values - Part 2

5 participants