Skip to content

fix:feat: support Blockaid What's New Dark Theme and add useTheme util#22613

Merged
digiwand merged 4 commits intodevelopfrom
fix-blockaid-whats-new-png-dark-mode-support
Jan 23, 2024
Merged

fix:feat: support Blockaid What's New Dark Theme and add useTheme util#22613
digiwand merged 4 commits intodevelopfrom
fix-blockaid-whats-new-png-dark-mode-support

Conversation

@digiwand
Copy link
Copy Markdown
Contributor

@digiwand digiwand commented Jan 20, 2024 •
edited
Loading

Description

  • Fixes Blockaid What's New Dark mode support
  • Create useTheme util

Related issues

Fixes: #22598

Manual testing steps

  1. Have a new instance of the wallet to populate the What's New modal
  2. Test the UI in light and dark mode

Screenshots/Recordings

Before

Screenshot 2024-01-19 at 7 59 17 AM

After

Screenshot 2024-01-19 at 8 31 14 AM

Light mode (no changes)

Screenshot 2024-01-19 at 8 53 10 AM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner January 20, 2024 00:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 20, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona added the team-confirmations-secure-ux-PR PRs from the confirmations team label Jan 22, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (16b62a8) 68.12% compared to head (549b535) 68.12%.

Files Patch % Lines
shared/notifications/index.js 66.67% 2 Missing ⚠️
ui/hooks/useTheme.ts 88.24% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22613      +/-   ##
===========================================
+ Coverage    68.12%   68.12%   +0.01%     
===========================================
  Files         1086     1087       +1     
  Lines        42619    42643      +24     
  Branches     11340    11349       +9     
===========================================
+ Hits         29030    29049      +19     
- Misses       13589    13594       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digiwand
refactor: add ONLY_INCLUDE_IF(blockaid)
428dd59 
guardrails for whats-new-popup
jpuri
jpuri reviewed Jan 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 22, 2024

Builds ready [428dd59]
Page Load Metrics (1328 ± 124 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint862741485727
domContentLoaded9198455728
load79816981328258124
domInteractive9198455728
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.17 KiB (0.02%)
  • common: 67 Bytes (0.00%)

@digiwand digiwand changed the title fix:feat: support blockaid what's new dark theme fix:feat: support Blockaid What's New Dark Theme and add useTheme util Jan 22, 2024
@digiwand digiwand merged commit ac64a48 into develop Jan 23, 2024
@digiwand digiwand deleted the fix-blockaid-whats-new-png-dark-mode-support branch January 23, 2024 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

+1 more reviewer

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.10.0 Issue or pull request that will be included in release 11.10.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM What's new image not readable for dark mode

5 participants

@digiwand @metamaskbot @jpuri @blackdevelopa @seaona