Added wait for the overlay spinner before the click was performed#22622
Merged
HowardBraham merged 4 commits intodevelopfrom Jan 23, 2024
Merged
Added wait for the overlay spinner before the click was performed#22622HowardBraham merged 4 commits intodevelopfrom
HowardBraham merged 4 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22622 +/- ##
========================================
Coverage 68.12% 68.12%
========================================
Files 1087 1087
Lines 42653 42653
Branches 11349 11349
========================================
Hits 29056 29056
Misses 13597 13597 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [b760c73]
Page Load Metrics (1215 ± 118 ms)
Bundle size diffs
|
Collaborator
Builds ready [03251a4]
Page Load Metrics (1366 ± 151 ms)
Bundle size diffs
|
chloeYue
approved these changes
Jan 23, 2024
Contributor
chloeYue
left a comment
There was a problem hiding this comment.
Tested locally, works good.
danjm
approved these changes
Jan 23, 2024
Collaborator
Builds ready [fd45e22]
Page Load Metrics (1282 ± 144 ms)
Bundle size diffs
|
Collaborator
Builds ready [fd45e22]
Page Load Metrics (1282 ± 144 ms)
Bundle size diffs
|
HowardBraham
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tries to fix the "Settings - general tab, validate the change language functionality: User selects "Dansk" language and verify that navigating to a different page does not affect"
Related issues
Fixes: #22566
Screenshot of the cicrcleCI console log
