Description

I can't say that this is completely fixed, but it's much much better.

The changes

• Upgraded snap-simple-keyring from 1.0.1 to 1.1.1
• driver.clickElement on the new data-testid that became available in 1.1.1
• added one driver.delay
• Started using TEST_SNAPS_SIMPLE_KEYRING_WEBSITE_URL in more places, which required moving it to a different file for Storybook usage

My testing procedure

I ran the 12 tests in the test/e2e/accounts folder 625 times each
...yes, I seriously did run them 625 times because I ran the whole suite on

• 5 build types: test-e2e-chrome-flask, test-e2e-firefox-flask, test-e2e-chrome, test-e2e-firefox, and test-e2e-chrome-multichain
• 25 parallelism each
• 5 times on each VM

5 x 25 x 5 = 625 runs of the test suite
625 runs x 12 tests = 7,500 individual tests

Out of those 7,500 individual tests, there were only 13 failures. Not zero, but much much better than before.
You can see these results with 7,500 tests here: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/67476/workflows/b1a5ccea-c241-41d9-8247-5e71909dde83

Related issues

Fixes: #22575

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.