Fix #22571 - Prevent flakiness in Import test#22612
Merged
HowardBraham merged 3 commits intodevelopfrom Jan 22, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vthomas13
approved these changes
Jan 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22612 +/- ##
========================================
Coverage 68.11% 68.11%
========================================
Files 1086 1086
Lines 42628 42628
Branches 11340 11340
========================================
+ Hits 29033 29035 +2
+ Misses 13595 13593 -2 ☔ View full report in Codecov by Sentry. |
HowardBraham
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on the sample failure cited in the issue, it appears the loading overlay is causing flakiness in the Import test. Checking to ensure the loading overlay is not there should prevent the problem.
Related issues
Fixes: #22571
Manual testing steps
N/A, just need the test to pass.
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist