fix: Fix phishing warning page unresponsiveness#22645
Merged
HowardBraham merged 3 commits intodevelopfrom Jan 23, 2024
Merged
Conversation
FrederikBolding
previously approved these changes
Jan 23, 2024
Collaborator
Builds ready [0621ae4]
Page Load Metrics (846 ± 67 ms)
Bundle size diffs
|
The phishing warning page was unresponsive on Chrome v122. This update resolves the issue. See changelog for details: https://github.com/MetaMask/phishing-warning/blob/main/CHANGELOG.md#303
0621ae4 to
838354a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22645 +/- ##
===========================================
+ Coverage 68.12% 68.13% +0.01%
===========================================
Files 1087 1087
Lines 42661 42661
Branches 11349 11349
===========================================
+ Hits 29062 29065 +3
+ Misses 13599 13596 -3 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [838354a]
Page Load Metrics (800 ± 19 ms)
Bundle size diffs
|
legobeat
approved these changes
Jan 23, 2024
HowardBraham
approved these changes
Jan 23, 2024
Collaborator
|
Missing release label release-11.7.5 on PR. Adding release label release-11.7.5 on PR and removing other release labels(release-11.10.0), as PR was cherry-picked in branch 11.7.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The phishing warning page was unresponsive on Chrome v122. This update resolves the issue.
See changelog for details: https://github.com/MetaMask/phishing-warning/blob/main/CHANGELOG.md#303
Related issues
Related to the issue described in #22533
Manual testing steps
Testing on Chrome Canary (v122) is recommended, that's the only browser we've confirmed as not working previous to this PR.
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist