Conversation
Bumps LavaMoat and SES to fix an issue with lockdown failing on Chrome Canary, making the extension unable to boot. This PR also re-applies a patch to `lavamoat-core` and deletes an outdated patch to `@lavamoat/lavapack` that is not required anymore since lavapack now defaults to relative paths. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
The phishing warning page was unresponsive on Chrome v122. This update resolves the issue. See changelog for details: https://github.com/MetaMask/phishing-warning/blob/main/CHANGELOG.md#303 Related to the issue described in #22533 1. Navigate to a blocked site 2. See that the phishing warning page shows up 3. Ensure that the three buttons/links work correctly ("report a detection problem", "continue to the site", and "Back to safety") Testing on Chrome Canary (v122) is recommended, that's the only browser we've confirmed as not working previous to this PR.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
Builds ready [c63775a]
Page Load Metrics (433 ± 166 ms)
|
|
@SocketSecurity ignore-all The "new author" of the package mentioned is https://github.com/ljharb, and he is legit |
|
Tested Wallet Chat snap and Wallet Guard snap on latest Chrome Canary. And also some basic send token and deploy contract functionalities. QA passed! |
|
Chloe and I tested with success on Chrome Beta and Chrome Canary |
No description provided.