Skip to content

Adding metametrics to primary currency setting#22481

Merged
vthomas13 merged 4 commits intodevelopfrom
metametrics-currency-settting
Jan 23, 2024
Merged

Adding metametrics to primary currency setting#22481
vthomas13 merged 4 commits intodevelopfrom
metametrics-currency-settting

Conversation

@vthomas13
Copy link
Copy Markdown
Contributor

@vthomas13 vthomas13 commented Jan 10, 2024 •
edited
Loading

Description

We want to collect data to help make the decision on whether we want to remove user preferred currency setting.
To do this, we are adding a Metametrics trait and events to help track the state and changing of settings related to Native/Fiat preference.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1900

Manual testing steps

  1. Open app
  2. Toggle User Currency setting
  3. Verify data in Metametrics

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 10, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vthomas13 vthomas13 force-pushed the metametrics-currency-settting branch 2 times, most recently from 717f77f to db1b02b Compare January 17, 2024 15:30
@vthomas13 vthomas13 marked this pull request as ready for review January 17, 2024 16:50
@vthomas13 vthomas13 requested a review from a team as a code owner January 17, 2024 16:50
@vthomas13 vthomas13 changed the title WIP: adding metametrics to primary currency setting Adding metametrics to primary currency setting Jan 17, 2024
@vthomas13 vthomas13 force-pushed the metametrics-currency-settting branch from a19837f to ecfe1ab Compare January 18, 2024 16:54
darkwing
darkwing previously approved these changes Jan 18, 2024
View reviewed changes
@vthomas13 vthomas13 requested a review from NidhiKJha January 18, 2024 18:49
NidhiKJha
NidhiKJha previously approved these changes Jan 22, 2024
View reviewed changes
@vthomas13 vthomas13 dismissed stale reviews from NidhiKJha and darkwing via e303782 January 23, 2024 15:53
@vthomas13 vthomas13 force-pushed the metametrics-currency-settting branch from 9a712df to e303782 Compare January 23, 2024 15:53
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f69e67d) 68.12% compared to head (e303782) 68.12%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...es/settings/settings-tab/settings-tab.component.js 62.50% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22481   +/-   ##
========================================
  Coverage    68.12%   68.12%           
========================================
  Files         1086     1086           
  Lines        42629    42637    +8     
  Branches     11340    11340           
========================================
+ Hits         29037    29043    +6     
- Misses       13592    13594    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 23, 2024

Builds ready [e303782]
Page Load Metrics (1130 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint852781586833
domContentLoaded9186646933
load80018031130248119
domInteractive9186646933
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 97 Bytes (0.00%)
  • ui: 214 Bytes (0.00%)
  • common: 158 Bytes (0.00%)

@vthomas13 vthomas13 merged commit 5bc11e4 into develop Jan 23, 2024
@vthomas13 vthomas13 deleted the metametrics-currency-settting branch January 23, 2024 19:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.10.0 Issue or pull request that will be included in release 11.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vthomas13 @metamaskbot @darkwing @NidhiKJha