Skip to content

deps: @metamask/eth-token-tracker@^4.0.0->^7.0.1#22352

Merged
HowardBraham merged 13 commits intoMetaMask:developfrom
legobeat:deps-eth-token-tracker
Jan 24, 2024
Merged

deps: @metamask/eth-token-tracker@^4.0.0->^7.0.1#22352
HowardBraham merged 13 commits intoMetaMask:developfrom
legobeat:deps-eth-token-tracker

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Dec 20, 2023 •
edited
Loading

Description

Removes dependencies on deprecated ethjs packages.

Changelog: https://github.com/MetaMask/eth-token-tracker/blob/main/CHANGELOG.md#701---2023-12-20

Related issues

Based on:

Manual testing steps

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 20, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Dec 20, 2023
@socket-security
Copy link
Copy Markdown

socket-security bot commented Dec 20, 2023 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-token-tracker@7.0.1 Transitive: environment, eval, filesystem, network +87 12.7 MB lgbot

🚮 Removed packages: npm/@metamask/eth-token-tracker@4.1.0, npm/ethjs-contract@0.2.3, npm/ethjs-filter@0.1.8, npm/ethjs-format@0.2.7, npm/ethjs-provider-http@0.1.6, npm/ethjs-query@0.3.8, npm/ethjs-rpc@0.2.0, npm/ethjs@0.4.0

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Dec 20, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat legobeat force-pushed the deps-eth-token-tracker branch 2 times, most recently from c977ae2 to bab69fe Compare December 22, 2023 16:58
@legobeat legobeat force-pushed the deps-eth-token-tracker branch 2 times, most recently from 1c7c570 to 28e9d78 Compare January 4, 2024 21:56
@legobeat legobeat force-pushed the deps-eth-token-tracker branch 2 times, most recently from e0e5434 to f47f6b8 Compare January 11, 2024 12:30
@legobeat legobeat mentioned this pull request Jan 15, 2024
Closed
13 tasks
@legobeat legobeat force-pushed the deps-eth-token-tracker branch 2 times, most recently from ca70849 to a46ed80 Compare January 15, 2024 11:42
@legobeat legobeat marked this pull request as ready for review January 15, 2024 11:58
@legobeat legobeat requested review from a team as code owners January 15, 2024 11:58
@legobeat legobeat force-pushed the deps-eth-token-tracker branch from ac93042 to 7df71f2 Compare January 18, 2024 14:52
@legobeat legobeat force-pushed the deps-eth-token-tracker branch from f469779 to e058be1 Compare January 22, 2024 08:51
@legobeat legobeat mentioned this pull request Jan 23, 2024
Merged
13 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b14ecc) 68.12% compared to head (9a6a30e) 68.11%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22352      +/-   ##
===========================================
- Coverage    68.12%   68.11%   -0.00%     
===========================================
  Files         1086     1086              
  Lines        42629    42629              
  Branches     11340    11340              
===========================================
- Hits         29037    29036       -1     
- Misses       13592    13593       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

digiwand
digiwand previously approved these changes Jan 23, 2024
View reviewed changes
@legobeat legobeat requested a review from a team January 23, 2024 16:34
HowardBraham pushed a commit that referenced this pull request Jan 23, 2024
@legobeat
deps: eth-method-registry@^2.0.0->^3.0.0 (#22351)
9625bc1 
- Based on: #21884 
- Base for: #22352
@legobeat legobeat requested a review from digiwand January 23, 2024 23:01
@legobeat legobeat requested a review from a team January 23, 2024 23:47
@HowardBraham HowardBraham merged commit 8182497 into MetaMask:develop Jan 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

+1 more reviewer

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file team-application-security Application security team type-security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat @HowardBraham @digiwand