Skip to content

chore: Upgrade @metamask/eth-token-tracker to v7.0.1#22502

Closed
Gudahtt wants to merge 3 commits intodevelopfrom
upgrade-token-tracker-to-v7
Closed

chore: Upgrade @metamask/eth-token-tracker to v7.0.1#22502
Gudahtt wants to merge 3 commits intodevelopfrom
upgrade-token-tracker-to-v7

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 11, 2024

Description

The package @metamask/token-tracker has been upgraded from v4 to `v7.0.1. The breaking changes were mostly bumps to the minimum Node.js version, which doesn't impact this project because we're still above the current minimum in v7.

The only other breaking change was an update to the block tracker, which is exposed as a public property of the token tracker class. We don't use that property in the extension, so this change has no impact.

Changelog: https://github.com/MetaMask/eth-token-tracker/blob/main/CHANGELOG.md#701---2023-12-20

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt added the team-extension-platform Extension Platform team label Jan 11, 2024
@Gudahtt Gudahtt force-pushed the upgrade-token-tracker-to-v7 branch from 1b866fb to a501e26 Compare January 11, 2024 22:23
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 11, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 11, 2024

Policies updated

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 11, 2024

Builds ready [1b17936]
Page Load Metrics (1222 ± 122 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint932651546330
domContentLoaded9187566933
load83717791222254122
domInteractive9187566933
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -2.05 KiB (-0.06%)
  • ui: 1.29 KiB (0.02%)
  • common: 9.7 KiB (0.19%)

@Gudahtt Gudahtt marked this pull request as ready for review January 11, 2024 23:37
@Gudahtt Gudahtt requested review from a team as code owners January 11, 2024 23:37
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 12, 2024

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/eth-token-tracker 4.1.0...7.0.1 None +1/-1 114 kB lgbot

HowardBraham
HowardBraham previously approved these changes Jan 12, 2024
View reviewed changes
@Gudahtt Gudahtt force-pushed the upgrade-token-tracker-to-v7 branch from 1b17936 to 11d3aa7 Compare January 12, 2024 15:41
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 12, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 12, 2024

Policies updated

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 12, 2024

Builds ready [5d72f7d]
Page Load Metrics (1217 ± 93 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint892771436431
domContentLoaded9193536833
load7991533121719493
domInteractive9193536833
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -2.05 KiB (-0.06%)
  • ui: 1.29 KiB (0.02%)
  • common: 9.7 KiB (0.19%)

@Gudahtt Gudahtt force-pushed the upgrade-token-tracker-to-v7 branch from 5d72f7d to 48a8e44 Compare January 12, 2024 17:42
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@e889bfe). Click here to learn what that means.

❗ Current head 48a8e44 differs from pull request most recent head cf5a257. Consider uploading reports for the commit cf5a257 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #22502   +/-   ##
==========================================
  Coverage           ?   68.05%           
==========================================
  Files              ?     1083           
  Lines              ?    42540           
  Branches           ?    11368           
==========================================
  Hits               ?    28950           
  Misses             ?    13590           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 12, 2024

Builds ready [48a8e44]
Page Load Metrics (1198 ± 111 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1012661836230
domContentLoaded10181837536
load81016371198230111
domInteractive9181837536

Gudahtt and others added 3 commits January 12, 2024 17:17
@Gudahtt
chore: Upgrade @metamask/token-tracker to v7.0.1
3c29690 
The package `@metamask/token-tracker` has been upgraded from v4 to
`v7.0.1. The breaking changes were mostly bumps to the minimum Node.js
version, which doesn't impact this project because we're still above
the current minimum in v7.

The only other breaking change was an update to the block tracker,
which is exposed as a public property of the token tracker class. We
don't use that property in the extension, so this change has no impact.

Changelog: https://github.com/MetaMask/eth-token-tracker/blob/main/CHANGELOG.md#701---2023-12-20
@metamaskbot @Gudahtt
Update LavaMoat policies
b32beb9
@metamaskbot @Gudahtt
Update LavaMoat policies
cf5a257
@Gudahtt Gudahtt force-pushed the upgrade-token-tracker-to-v7 branch from 48a8e44 to cf5a257 Compare January 12, 2024 20:47
@legobeat
Copy link
Copy Markdown
Contributor

legobeat commented Jan 15, 2024

@Gudahtt Gudahtt changed the title chore: Upgrade @metamask/token-tracker to v7.0.1 chore: Upgrade @metamask/eth-token-tracker to v7.0.1 Jan 15, 2024
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Jan 15, 2024

Oh, thanks @legobeat ! Closed in favor of #22352

@Gudahtt Gudahtt closed this Jan 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
@HowardBraham HowardBraham deleted the upgrade-token-tracker-to-v7 branch January 19, 2026 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham left review comments

Assignees

No one assigned

Labels

team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gudahtt @metamaskbot @legobeat @HowardBraham