deps: ethjs@^0.4.0 -> @metamask/ethjs@^0.5.1#21884
Closed
legobeat wants to merge 4 commits intoMetaMask:developfrom
Closed
deps: ethjs@^0.4.0 -> @metamask/ethjs@^0.5.1#21884legobeat wants to merge 4 commits intoMetaMask:developfrom
legobeat wants to merge 4 commits intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This was referenced Nov 27, 2023
Merged
01b0290 to
31ef161
Compare
NEllusion
reviewed
Dec 7, 2023
Contributor
NEllusion
left a comment
There was a problem hiding this comment.
Changes LGTM. Tests are passing locally as well, and running MM (without lavamoat) works fine. Was unable to get it running with lavamoat for some reason, but looks unrelated to this PR as it occurs for me on develop as well.
Another review will be required after the rebase
NEllusion
previously approved these changes
Dec 7, 2023
Contributor
NEllusion
left a comment
There was a problem hiding this comment.
LGTM once flakey tests pass
c13ded8 to
21b58b0
Compare
a743b43 to
96990b4
Compare
f3517a4 to
81e03fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21884 +/- ##
===========================================
- Coverage 68.15% 68.15% -0.00%
===========================================
Files 1083 1083
Lines 42491 42491
Branches 11333 11333
===========================================
- Hits 28959 28957 -2
- Misses 13532 13534 +2 ☔ View full report in Codecov by Sentry. |
fadb8e5 to
f0b3e3c
Compare
HowardBraham
pushed a commit
that referenced
this pull request
Jan 23, 2024
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move from
ethjsto@metamask/ethjs. Gradual upgrade preparing for upcoming fixes. This (together with resulting transitive dependencies) should be a drop-in replacement with no user-facing changes.Release notes
Update from
ethjs@0.4.0to@metamask/ethjs@^0.5.1Update
@metamask/ethjs-queryfrom^0.5.0to^0.5.3Update from
ethjs-contract@^0.2.3to@metamask/ethjs-contract@^0.3.4Related issues
Pre-merge author checklist
Pre-merge reviewer checklist