updated e2e for account unpinning#22632
Merged
HowardBraham merged 3 commits intodevelopfrom Jan 23, 2024
Merged
Conversation
Comment on lines
+251
to
+252
| const exists = await driver.isElementPresent(pinnedIcon); | ||
| assert.equal(exists, false, 'Unpinned Account'); |
Contributor
There was a problem hiding this comment.
Have you tried driver.waitForElementNotPresent()?
Member
Author
There was a problem hiding this comment.
Thanks @HowardBraham, really nice suggestion! Updated here 47b5271
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22632 +/- ##
========================================
Coverage 68.12% 68.12%
========================================
Files 1087 1087
Lines 42653 42653
Branches 11349 11349
========================================
Hits 29056 29056
Misses 13597 13597 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [f563915]
Page Load Metrics (1228 ± 113 ms)
Bundle size diffs
|
darkwing
approved these changes
Jan 23, 2024
HowardBraham
approved these changes
Jan 23, 2024
Collaborator
Builds ready [5231a7e]
Page Load Metrics (1291 ± 127 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix the test, so that when the user clicks on unpin the account. The account is unpinned properly.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist