Fixing Broken TokenAllowance Story#20422
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@NidhiKJha Could you please review this pr? |
NidhiKJha
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution
|
@georgewrmarshall Could you please review this pr? |
georgewrmarshall
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution @Jainex17
…h component library components
2145bf9
|
Still a few more selector updates that need to be made to get this to pass. Let me know if you need some assistance @Jainex17 |
Thanks, I'm still making an effort, but having some steps from you to resolve this build issue would be incredibly helpful. |
georgewrmarshall
left a comment
There was a problem hiding this comment.
LGTM! Hey @Jainex17, to get this PR in I reverted the changes to the token allowance files and we can open another PR to swap out the deprecated components. Thanks for your contribution
…s which should help us see all alerts in one view
13cb809
| metamask: { | ||
| ...testData.metamask, | ||
| // TODO: Mock state correctly to show insufficient funds error | ||
| // | ||
| accounts: { | ||
| ...testData.metamask.accounts, | ||
| '0x9d0ba4ddac06032527b140912ec808ab9451b788': { | ||
| balance: '0x0', | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Hey @matthewwalsh0, do you have any ideas on how one could show the insufficient funds for gas error? I seem to be struggling with that
kumavis
left a comment
There was a problem hiding this comment.
thank you for this!
the After video shows a bug suggesting some type error: "Spending cap request for your [Object object]"
|
Awesome to see this working @Jainex17! @kumavis I created a follow-up ticket for us to address here: #21405 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #20422 +/- ##
===========================================
- Coverage 68.82% 68.81% -0.00%
===========================================
Files 1034 1034
Lines 41166 41166
Branches 10994 10994
===========================================
- Hits 28329 28327 -2
- Misses 12837 12839 +2 ☔ View full report in Codecov by Sentry. |
|
@georgewrmarshall Sorry for being inactive is there anything i can do in this PR Thanks |
Explanation
The
TokenAllowancestory was not being displayed in the Storybook. This PR resolves the issue and now it is shown in the Storybook.chnages made
token-allowance.stories-to-do.jstotoken-allowance.stories.js.token-allowance.stories.js.AllBannerAlertstory to display all alertsScreenshots/Screencaps
Before
before.mov
After
after.mov
Manual Testing Steps
TokenAllowancePre-merge author checklist
Pre-merge reviewer checklist