Part of #20163 for file ui\components\app\create-new-vault\create-new-vault.js#20535
Merged
garrettbear merged 13 commits intoMetaMask:developfrom Jan 24, 2024
Conversation
…eate-new-vault.js
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…ents-app-create-new-vault-create-new-vault.js
…ents-app-create-new-vault-create-new-vault.js
garrettbear
reviewed
Aug 24, 2023
Contributor
|
Updated the |
…ents-app-create-new-vault-create-new-vault.js
…ents-app-create-new-vault-create-new-vault.js
Contributor
|
Hey @PrgrmrHarshShukla, could you resolve the issues with the unit tests failing on this PR? |
…ents-app-create-new-vault-create-new-vault.js
…ents-app-create-new-vault-create-new-vault.js
georgewrmarshall
approved these changes
Sep 26, 2023
Contributor
georgewrmarshall
left a comment
There was a problem hiding this comment.
LGTM! I updated the test so that it should pass now. Thanks for your contribution @PrgrmrHarshShukla
…ents-app-create-new-vault-create-new-vault.js
…ents-app-create-new-vault-create-new-vault.js
…ents-app-create-new-vault-create-new-vault.js
…ents-app-create-new-vault-create-new-vault.js
garrettbear
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR is a part of the issue #20163 Replace deprecated CheckBox component with Checkbox from the component-library for file
ui\components\app\create-new-vault\create-new-vault.jsScreenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.