Skip to content

fix(14311): display explorer domain instead of hardcoded Etherscan explorer name#22483

Merged
Akaryatrh merged 2 commits intodevelopfrom
fix/14311
Jan 23, 2024
Merged

fix(14311): display explorer domain instead of hardcoded Etherscan explorer name#22483
Akaryatrh merged 2 commits intodevelopfrom
fix/14311

Conversation

@Akaryatrh
Copy link
Copy Markdown
Contributor

@Akaryatrh Akaryatrh commented Jan 10, 2024 •
edited
Loading

Description

This PR displays the explorer domain on hover on account list links instead of the currently hardcoded Etherscan explorer name (not matter what was the selected network)

Related issues

Fixes: #14311

Manual testing steps

  1. Go to Add hardware wallet
  2. On the ledger device, unlock it if necessary and select Eth app
  3. On the Connect a hardware wallet page, Click on Ledger and then continue
  4. On the browser, click on the nano and then continue
  5. On the account list, hover on any explorer links. It should match the selected network explorer domain.

Screenshots/Recordings

Before

Capture d’écran 2024-01-11 à 10 40 34

After

Capture d’écran 2024-01-11 à 10 55 55 Capture d’écran 2024-01-11 à 10 56 42

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Akaryatrh
Copy link
Copy Markdown
Contributor Author

Akaryatrh commented Jan 10, 2024

I have read the CLA Document and I hereby sign the CLA

@Akaryatrh Akaryatrh marked this pull request as ready for review January 11, 2024 10:03
@Akaryatrh Akaryatrh requested a review from a team as a code owner January 11, 2024 10:03
@Akaryatrh Akaryatrh added the team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead label Jan 11, 2024
@Akaryatrh Akaryatrh force-pushed the fix/14311 branch 4 times, most recently from c8d037e to bf03718 Compare January 12, 2024 13:41
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 12, 2024

Builds ready [bf03718]
Page Load Metrics (1415 ± 157 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1053241916732
domContentLoaded18209666933
load88919291415327157
domInteractive18209666933
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 8 Bytes (0.00%)
  • common: 51 Bytes (0.00%)

@Akaryatrh Akaryatrh force-pushed the fix/14311 branch 2 times, most recently from b0d6034 to e371656 Compare January 15, 2024 14:50
@Akaryatrh Akaryatrh force-pushed the fix/14311 branch 4 times, most recently from af0a4e7 to 1af4576 Compare January 22, 2024 13:30
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d720bb9) 68.11% compared to head (56b9fee) 68.12%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22483   +/-   ##
========================================
  Coverage    68.11%   68.12%           
========================================
  Files         1086     1086           
  Lines        42628    42629    +1     
  Branches     11340    11340           
========================================
+ Hits         29035    29037    +2     
+ Misses       13593    13592    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 23, 2024

Builds ready [56b9fee]
Page Load Metrics (1295 ± 136 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint952991977636
domContentLoaded10205858139
load91718361295283136
domInteractive10205858139
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 8 Bytes (0.00%)
  • common: 51 Bytes (0.00%)

@Akaryatrh Akaryatrh merged commit 4b14ecc into develop Jan 23, 2024
@Akaryatrh Akaryatrh deleted the fix/14311 branch January 23, 2024 09:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.10.0 Issue or pull request that will be included in release 11.10.0 team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Message "View Account on Etherscan" even though it's taking me to another Blockchain Explorer

4 participants

@Akaryatrh @metamaskbot @darkwing @NidhiKJha