Skip to content

Sync: make sure get_plugins exists before to use it.#7213

Merged
dereksmart merged 1 commit intomasterfrom
fix/fatal-get-plugins
May 26, 2017
Merged

Sync: make sure get_plugins exists before to use it.#7213
dereksmart merged 1 commit intomasterfrom
fix/fatal-get-plugins

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented May 19, 2017

Fixes the Fatal error reported here:

[17-May-2017 17:05:03 UTC] PHP Fatal error:  Uncaught Error: Call to undefined function get_plugins() in /wp-content/plugins/jetpack/sync/class.jetpack-sync-module-plugins.php:114
Stack trace:
#0 /wp-includes/class-wp-hook.php(300): Jetpack_Sync_Module_Plugins->expand_plugin_data(Array)
#1 /wp-includes/plugin.php(203): WP_Hook->apply_filters(Array, Array)
#2 /wp-content/plugins/jetpack/sync/class.jetpack-sync-sender.php(145): apply_filters('jetpack_sync_be...', Array, 1)
#3 /wp-content/plugins/jetpack/sync/class.jetpack-sync-sender.php(193): Jetpack_Sync_Sender->get_items_to_send(Object(Jetpack_Sync_Queue_Buffer), true)
#4 /wp-content/plugins/jetpack/sync/class.jetpack-sync-sender.php(98): Jetpack_Sync_Sender->do_sync_for_queue(Object(Jetpack_Sync_Queue))
#5 /wp-content/plugins/jetpack/sync/class.jetpack-sync-sender.php(80): Jetpack_Sync_Sender->do_sync_and_set_delays(Object(Jetpac in /wp-content/plugins/jetpack/sync/class.jetpack-sync-module-plugins.php on line 114

The problem seems similar to the one we had a little while back in #4233.

What's odd is that the user reports seeing this in their logs every few minutes. Isn't this supposed to be triggered only when activating or deactivating plugins?

cc @enejb and @lezama who worked on the related PR last time, #4238.

Proposed changelog entry for your changes:

  • Sync: avoid Fatal errors when activating or deactivating plugins.

@jeherve jeherve added [Package] Sync [Pri] Normal [Status] Needs Review This PR is ready for review. [Team] Poseidon Bug When a feature is broken and / or not performing as intended labels May 19, 2017
@jeherve jeherve self-assigned this May 19, 2017
@jeherve jeherve requested review from enejb and lezama May 19, 2017 20:35
@georgestephanis georgestephanis removed the [Status] Needs Review This PR is ready for review. label May 24, 2017
@jeherve jeherve added the [Status] Ready to Merge Go ahead, you can push that green button! label May 25, 2017
@enejb
Copy link
Copy Markdown
Member

enejb commented May 25, 2017

It is strange that we see it in the logs that often. My guess is that the callable are never synced properly over because of the error. So we were trying ever few minutes.

Thanks for the fix @jeherve :shipit:

enejb
enejb approved these changes May 25, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good!

@jeherve jeherve modified the milestone: 5.0 May 26, 2017
@dereksmart dereksmart merged commit 748e1c1 into master May 26, 2017
@dereksmart dereksmart deleted the fix/fatal-get-plugins branch May 26, 2017 18:12
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 26, 2017
jeherve added a commit that referenced this pull request May 29, 2017
@jeherve
Changelog: add #7213
aac5d73
eliorivero pushed a commit that referenced this pull request May 30, 2017
@jeherve @eliorivero
Changelog: first pass at a changelog for 5.0 (#7116)
eee27f0 
* Changelog: first pass at a changelog for 5.0

* Changelog: delete 4.9 testing list.

* Changelog: update minimum WP version to match ver. in jetpack.php

Fixes #7158

* Changelog: add #6051

* Changelog: add #6753

* Changelog: add #6928

* Changelog: add #6964

* Changelog: add #7014

* Changelog: add #7057

* Changelog: add #7060

* Changelog: add #7068

* Changelog: add #7070

* Changelog: add #7072

* Changelog: add #7071

* Changelog: add release date and post shortlink.

* Changelog: add #7094

* Changelog: add #7100

* Changelog: add #7108

* Changelog: add #7113

* Changelog: add #7123

* Changelog: add #7135

* Changelog: add #7143

* Changelog: add #7151

* Changelog: add #6996

* Changelog: add #7105

* Changelog: add #7132

* Changelog: add #7166

* Changelog: fix typo in 4.9 changelog.

* Changelog: remove older releases' changelogs.

@see p1HpG7-42e-p2

* Changelog: add #7090

* Changelog: add #7095

* Changelog: add #7112

* Changelog: add #7115

* Changelog: add #7122

* Changelog: add #7137

* Changelog: add #7138

* Changelog: add #7140

* Changelog: add #7154

* Changelog: add ##7155

* Changelog: add #7163

* Changelog: add #7167

* Changelog: add #7171

* Changelog: add #7180

* Changelog: add #7181

* Changelog: add #7183

* Changelog: add #7184

* Changelog: add #7189

* Changelog: add #7191

* Changelog: add #7193

* Changelog: add #7198

* Changelog: add #7200

* Changelog: add #7209

* Changelog: add #7212

* Testing list: add instructions for #7115

* Changelog: add #7188

* Changelog: add #7205

* Changelog: add #7225

* Changelog: add #6872

* Changelog: add #7107

* Changelog: add #7118

* Changelog: add #7142

* Changelog: add #7170

* Changelog: add #7210

* Changelog: add #7218

* Changelog: add #7232

* Changelog: add #7211

* Changelog: add #7213

* Changelog: add #7229

* Changelog: add #7230

* Changelog: add #7214

* Draft changelog for 5.0

* Changelog updates: 2nd pass at a clearer changelog.

- Fix typos.
- Use consistent tense and tone across all changelog.
- Remove unclear items.

* Changelog: add #7026

* Changelog: add #7058

* Changelog: add #7125

* Changelog: add #7249

* Changelog: add #7185

* add mentions of image widget migration

* Changelog: add info about new output for CLI command.

* Changelog: add WP version number matching the new Image Widget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enejb enejb enejb approved these changes

@lezama lezama Awaiting requested review from lezama

+1 more reviewer

@georgestephanis georgestephanis georgestephanis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

Bug When a feature is broken and / or not performing as intended [Package] Sync [Pri] Normal

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jeherve @enejb @georgestephanis @dereksmart