Merged
Conversation
57edf59 to
1413b37
Compare
Member
|
Howdy @gravityrail, is there anything in particular you'd like me to review? I'm out until tonight for a funeral, so I won't get a chance to take a look until at least mid-day tomorrow. |
Contributor
Author
|
Hi Derek, very sorry to hear that. I sort of chose you at random as a
second reviewer, happy for it to be someone else. I am out till tomorrow
and can explain more then about how to test to you or whomever would be a
good replacement.
…On May 9, 2017 9:18 AM, "Derek Springer" ***@***.***> wrote:
Howdy @gravityrail <https://github.com/gravityrail>, is there anything in
particular you'd like me to review? I'm out until tonight for a funeral, so
I won't get a chance to take a look until at least mid-day tomorrow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7112 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADKuExuitDjjZLA3hFEV3ACAiaLZHnAks5r4JHRgaJpZM4NOu_F>
.
|
ebinnion
reviewed
May 15, 2017
| @@ -0,0 +1,58 @@ | |||
| #!/usr/bin/env sh | |||
Contributor
There was a problem hiding this comment.
I'm not sure whether this belongs in bin or tools. Ping @dereksmart for input.
ebinnion
approved these changes
May 15, 2017
Contributor
ebinnion
left a comment
There was a problem hiding this comment.
I don't have any comments on the code at this time.
I tested the connect flow by clicking the connect button in the admin and didn't notice a regression.
I also tested the CLI command that was suggested in the first comment of this PR and it worked fine. I got back:
{
"success": true,
"next_url": "https://jetpack.wordpress.com/jetpack.authorize/1/?jp_version=5.0-alpha&calypso_env&..."
}
With that in mind, I'm fine with merging this as a work in progress.
eliorivero
pushed a commit
that referenced
this pull request
May 30, 2017
* Changelog: first pass at a changelog for 5.0 * Changelog: delete 4.9 testing list. * Changelog: update minimum WP version to match ver. in jetpack.php Fixes #7158 * Changelog: add #6051 * Changelog: add #6753 * Changelog: add #6928 * Changelog: add #6964 * Changelog: add #7014 * Changelog: add #7057 * Changelog: add #7060 * Changelog: add #7068 * Changelog: add #7070 * Changelog: add #7072 * Changelog: add #7071 * Changelog: add release date and post shortlink. * Changelog: add #7094 * Changelog: add #7100 * Changelog: add #7108 * Changelog: add #7113 * Changelog: add #7123 * Changelog: add #7135 * Changelog: add #7143 * Changelog: add #7151 * Changelog: add #6996 * Changelog: add #7105 * Changelog: add #7132 * Changelog: add #7166 * Changelog: fix typo in 4.9 changelog. * Changelog: remove older releases' changelogs. @see p1HpG7-42e-p2 * Changelog: add #7090 * Changelog: add #7095 * Changelog: add #7112 * Changelog: add #7115 * Changelog: add #7122 * Changelog: add #7137 * Changelog: add #7138 * Changelog: add #7140 * Changelog: add #7154 * Changelog: add ##7155 * Changelog: add #7163 * Changelog: add #7167 * Changelog: add #7171 * Changelog: add #7180 * Changelog: add #7181 * Changelog: add #7183 * Changelog: add #7184 * Changelog: add #7189 * Changelog: add #7191 * Changelog: add #7193 * Changelog: add #7198 * Changelog: add #7200 * Changelog: add #7209 * Changelog: add #7212 * Testing list: add instructions for #7115 * Changelog: add #7188 * Changelog: add #7205 * Changelog: add #7225 * Changelog: add #6872 * Changelog: add #7107 * Changelog: add #7118 * Changelog: add #7142 * Changelog: add #7170 * Changelog: add #7210 * Changelog: add #7218 * Changelog: add #7232 * Changelog: add #7211 * Changelog: add #7213 * Changelog: add #7229 * Changelog: add #7230 * Changelog: add #7214 * Draft changelog for 5.0 * Changelog updates: 2nd pass at a clearer changelog. - Fix typos. - Use consistent tense and tone across all changelog. - Remove unclear items. * Changelog: add #7026 * Changelog: add #7058 * Changelog: add #7125 * Changelog: add #7249 * Changelog: add #7185 * add mentions of image widget migration * Changelog: add info about new output for CLI command. * Changelog: add WP version number matching the new Image Widget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools for partners to provision Jetpack sites.
Jetpack Start allows third parties to provide and pay for Jetpack plans via a secure API call, and shortcuts some setup steps (optionally).
This PR is just a starting point, all it really does is move the register() and authorize() steps into a wp-cli command. Eventually the endpoint will do all kinds of other setup and checks on the WP side so that users are given the plans that partners have signed up for, etc.
Usage:
Testing instructions:
JETPACK_START_API_HOST=your.sandbox.host.com sh ./bin/partner-provision.sh --partner_id=$CLIENT_ID --partner_secret=$CLIENT_SECRET --plan=anything --user_id=$WP_USER_IDon a new WP installRight now, this doesn't do any setup beyond regular Jetpack Connect. Eventually it will. I want to get this merged before further work is done, since 99% of that work will be changes to WPCOM and this lets us test against a production version of Jetpack.