Conversation
|
This is a good chance to explain a bit about why some features don't fully work, like Post by Email. Perhaps we can update the text to something like this:
Also, the action button should say "connect" instead of "link" since we're now using "connect" for user accounts too. |
eliorivero
left a comment
There was a problem hiding this comment.
Remove all references to unused username prop, including reducers.
| ) { | ||
| const text = __( 'You, %(userName)s, are not connected to WordPress.com.', { | ||
| args: { | ||
| userName: this.props.username |
There was a problem hiding this comment.
Since this is no longer used, all its references either direct or indirect should be removed, for example
username: getUsername( state ),
|
@rickybanister @richardmuscat can we have your opinion here? |
|
@eliorivero I have removed the reducer import, connection and property passing, should be good to go now. |
|
Cool thanks! Let's wait until we know what design and growth think about this. |
|
@eliorivero which change would you like me to comment on? The actual PR diff, or your proposal above? @samhotchkiss can this PR have a before/after? |
|
The 'you are not connected to wordpress.com' text seems good to go, if that helps. |
|
@rickybanister whatever you consider more appropriate. If the change in the PR is ok, then let's go with it. |
|
@eliorivero @samhotchkiss I think it's safe to merge this now, all required reviews have been made. |
* Changelog: first pass at a changelog for 5.0 * Changelog: delete 4.9 testing list. * Changelog: update minimum WP version to match ver. in jetpack.php Fixes #7158 * Changelog: add #6051 * Changelog: add #6753 * Changelog: add #6928 * Changelog: add #6964 * Changelog: add #7014 * Changelog: add #7057 * Changelog: add #7060 * Changelog: add #7068 * Changelog: add #7070 * Changelog: add #7072 * Changelog: add #7071 * Changelog: add release date and post shortlink. * Changelog: add #7094 * Changelog: add #7100 * Changelog: add #7108 * Changelog: add #7113 * Changelog: add #7123 * Changelog: add #7135 * Changelog: add #7143 * Changelog: add #7151 * Changelog: add #6996 * Changelog: add #7105 * Changelog: add #7132 * Changelog: add #7166 * Changelog: fix typo in 4.9 changelog. * Changelog: remove older releases' changelogs. @see p1HpG7-42e-p2 * Changelog: add #7090 * Changelog: add #7095 * Changelog: add #7112 * Changelog: add #7115 * Changelog: add #7122 * Changelog: add #7137 * Changelog: add #7138 * Changelog: add #7140 * Changelog: add #7154 * Changelog: add ##7155 * Changelog: add #7163 * Changelog: add #7167 * Changelog: add #7171 * Changelog: add #7180 * Changelog: add #7181 * Changelog: add #7183 * Changelog: add #7184 * Changelog: add #7189 * Changelog: add #7191 * Changelog: add #7193 * Changelog: add #7198 * Changelog: add #7200 * Changelog: add #7209 * Changelog: add #7212 * Testing list: add instructions for #7115 * Changelog: add #7188 * Changelog: add #7205 * Changelog: add #7225 * Changelog: add #6872 * Changelog: add #7107 * Changelog: add #7118 * Changelog: add #7142 * Changelog: add #7170 * Changelog: add #7210 * Changelog: add #7218 * Changelog: add #7232 * Changelog: add #7211 * Changelog: add #7213 * Changelog: add #7229 * Changelog: add #7230 * Changelog: add #7214 * Draft changelog for 5.0 * Changelog updates: 2nd pass at a clearer changelog. - Fix typos. - Use consistent tense and tone across all changelog. - Remove unclear items. * Changelog: add #7026 * Changelog: add #7058 * Changelog: add #7125 * Changelog: add #7249 * Changelog: add #7185 * add mentions of image widget migration * Changelog: add info about new output for CLI command. * Changelog: add WP version number matching the new Image Widget.
Simple text change