Conversation
|
This tested fine for me. I don't have any comments on the code. As a note, other testers will need to set the |
class.json-api-endpoints.php
Outdated
| if ( !$cast_and_filter ) { | ||
| return $return; | ||
| if ( isset( $this->api->query['force'] ) && 'secure' === $this->api->query['force'] ) { | ||
| if ( isset( $return['secure_key'] ) ) { |
There was a problem hiding this comment.
Why not add this conditional to the compound conditional that encloses it since nothing else happens within it? e.g.
if ( isset( $this->api->query['force'] ) &&
'secure' === $this->api->query['force'] &&
isset( $return['secure_key'] ) {
class.json-api-endpoints.php
Outdated
| if ( isset( $this->api->query['force'] ) && 'secure' === $this->api->query['force'] ) { | ||
| if ( isset( $return['secure_key'] ) ) { | ||
| $post_body = $this->get_secure_body( $return['secure_key'] ); | ||
| $this->api->post_body = $post_body; |
There was a problem hiding this comment.
If nothing else is being done with $body_post, why not just set $this->api->post_body = $this->get_secure_body( $return['secure_key'] ); and eliminate line 273?
class.json-api-endpoints.php
Outdated
| return $this->cast_and_filter( $return, $this->request_format, $return_default_values ); | ||
|
|
||
| protected function get_secure_body( $secure_key ) { | ||
| $response = Jetpack_Client::wpcom_json_api_request_as_blog( sprintf( '/sites/%d/secure-request', Jetpack_Options::get_option('id' ) ), '1.1', array( 'method' => 'POST' ), array( 'secure_key' => $secure_key ) ); |
There was a problem hiding this comment.
This line is exceptionally long, consider spreading it over several lines, e.g.
$response = Jetpack_Client::wpcom_json_api_request_as_blog(
sprintf( '/sites/%d/secure-request', Jetpack_Options::get_option('id' ) ),
'1.1',
array( 'method' => 'POST' ),
array( 'secure_key' => $secure_key )
);
when calling endpoints with force=secure enforce the endpoint to relieve the request body by making a secure request to wpcom
13d966d to
7676e3e
Compare
Is it enough to point |
I haven't tried that. Seems reasonable though. |
|
I would expect this not to work as expected for you. Since the secure endpoint does't currently exist in production and so when the Jetpack site ( not your browser ) talks to |
rralian
left a comment
There was a problem hiding this comment.
tested this and it's working as expected for me. neat approach. 👍
|
|
||
|
|
||
| return $this->cast_and_filter( $return, $this->request_format, $return_default_values ); | ||
| protected function get_secure_body( $secure_key ) { |
* Changelog: first pass at a changelog for 5.0 * Changelog: delete 4.9 testing list. * Changelog: update minimum WP version to match ver. in jetpack.php Fixes #7158 * Changelog: add #6051 * Changelog: add #6753 * Changelog: add #6928 * Changelog: add #6964 * Changelog: add #7014 * Changelog: add #7057 * Changelog: add #7060 * Changelog: add #7068 * Changelog: add #7070 * Changelog: add #7072 * Changelog: add #7071 * Changelog: add release date and post shortlink. * Changelog: add #7094 * Changelog: add #7100 * Changelog: add #7108 * Changelog: add #7113 * Changelog: add #7123 * Changelog: add #7135 * Changelog: add #7143 * Changelog: add #7151 * Changelog: add #6996 * Changelog: add #7105 * Changelog: add #7132 * Changelog: add #7166 * Changelog: fix typo in 4.9 changelog. * Changelog: remove older releases' changelogs. @see p1HpG7-42e-p2 * Changelog: add #7090 * Changelog: add #7095 * Changelog: add #7112 * Changelog: add #7115 * Changelog: add #7122 * Changelog: add #7137 * Changelog: add #7138 * Changelog: add #7140 * Changelog: add #7154 * Changelog: add ##7155 * Changelog: add #7163 * Changelog: add #7167 * Changelog: add #7171 * Changelog: add #7180 * Changelog: add #7181 * Changelog: add #7183 * Changelog: add #7184 * Changelog: add #7189 * Changelog: add #7191 * Changelog: add #7193 * Changelog: add #7198 * Changelog: add #7200 * Changelog: add #7209 * Changelog: add #7212 * Testing list: add instructions for #7115 * Changelog: add #7188 * Changelog: add #7205 * Changelog: add #7225 * Changelog: add #6872 * Changelog: add #7107 * Changelog: add #7118 * Changelog: add #7142 * Changelog: add #7170 * Changelog: add #7210 * Changelog: add #7218 * Changelog: add #7232 * Changelog: add #7211 * Changelog: add #7213 * Changelog: add #7229 * Changelog: add #7230 * Changelog: add #7214 * Draft changelog for 5.0 * Changelog updates: 2nd pass at a clearer changelog. - Fix typos. - Use consistent tense and tone across all changelog. - Remove unclear items. * Changelog: add #7026 * Changelog: add #7058 * Changelog: add #7125 * Changelog: add #7249 * Changelog: add #7185 * add mentions of image widget migration * Changelog: add info about new output for CLI command. * Changelog: add WP version number matching the new Image Widget.
When calling endpoints with force=secure enforce the endpoint to relieve the request body by making a secure request to wpcom.
By doing a secondary call to WordPress.com over https to get the post body.
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes: