Fix/woocommerce order item meta sync#7105
Conversation
Make it clearer this whitelist is for the order items metadata and add some missing meta from coupon usage.
…e taxes are enabled.
|
Tested this by manually full syncing my test woo site and everything syncs ok, as far as I'm concerned this is good to merge. |
… to the definitions in Woo Commerce Core. Also removes _visibility because I can't see this documented anywhere in the code.
nabsul
left a comment
There was a problem hiding this comment.
Looks great, I'll try to get get testing it in my sandbox some time today.
| return array( | ||
| $order_items, | ||
| $this->get_metadata( $order_item_ids, 'order_item', $this->meta_whitelist ) | ||
| $this->get_metadata( $order_item_ids, 'order_item', $this->order_item_meta_whitelist ) |
There was a problem hiding this comment.
There wasn't a comma there before and adding one seems pretty unnecessary.
There was a problem hiding this comment.
@westi I'd +1 @nabsul's comment here. phpcs will complain if you don't add one, so it's probably best to fix this:
While we don't refactor code just for the sake of it, we try to adhere to WordPress coding standards when adding new code or editing existing lines.
Thanks!
nabsul
left a comment
There was a problem hiding this comment.
Tested against my sandbox. The meta data was received and no errors occurred.
jeherve
left a comment
There was a problem hiding this comment.
A minor change to make phpcs happy. :)
| return array( | ||
| $order_items, | ||
| $this->get_metadata( $order_item_ids, 'order_item', $this->meta_whitelist ) | ||
| $this->get_metadata( $order_item_ids, 'order_item', $this->order_item_meta_whitelist ) |
There was a problem hiding this comment.
@westi I'd +1 @nabsul's comment here. phpcs will complain if you don't add one, so it's probably best to fix this:
While we don't refactor code just for the sake of it, we try to adhere to WordPress coding standards when adding new code or editing existing lines.
Thanks!
|
Can this wait for the next major release, or is it causing issues and should go out in a point release sooner if one happens? |
|
@georgestephanis I don't think this needs to go in a point release, we can install the beta version on test sites for now. |
* Changelog: first pass at a changelog for 5.0 * Changelog: delete 4.9 testing list. * Changelog: update minimum WP version to match ver. in jetpack.php Fixes #7158 * Changelog: add #6051 * Changelog: add #6753 * Changelog: add #6928 * Changelog: add #6964 * Changelog: add #7014 * Changelog: add #7057 * Changelog: add #7060 * Changelog: add #7068 * Changelog: add #7070 * Changelog: add #7072 * Changelog: add #7071 * Changelog: add release date and post shortlink. * Changelog: add #7094 * Changelog: add #7100 * Changelog: add #7108 * Changelog: add #7113 * Changelog: add #7123 * Changelog: add #7135 * Changelog: add #7143 * Changelog: add #7151 * Changelog: add #6996 * Changelog: add #7105 * Changelog: add #7132 * Changelog: add #7166 * Changelog: fix typo in 4.9 changelog. * Changelog: remove older releases' changelogs. @see p1HpG7-42e-p2 * Changelog: add #7090 * Changelog: add #7095 * Changelog: add #7112 * Changelog: add #7115 * Changelog: add #7122 * Changelog: add #7137 * Changelog: add #7138 * Changelog: add #7140 * Changelog: add #7154 * Changelog: add ##7155 * Changelog: add #7163 * Changelog: add #7167 * Changelog: add #7171 * Changelog: add #7180 * Changelog: add #7181 * Changelog: add #7183 * Changelog: add #7184 * Changelog: add #7189 * Changelog: add #7191 * Changelog: add #7193 * Changelog: add #7198 * Changelog: add #7200 * Changelog: add #7209 * Changelog: add #7212 * Testing list: add instructions for #7115 * Changelog: add #7188 * Changelog: add #7205 * Changelog: add #7225 * Changelog: add #6872 * Changelog: add #7107 * Changelog: add #7118 * Changelog: add #7142 * Changelog: add #7170 * Changelog: add #7210 * Changelog: add #7218 * Changelog: add #7232 * Changelog: add #7211 * Changelog: add #7213 * Changelog: add #7229 * Changelog: add #7230 * Changelog: add #7214 * Draft changelog for 5.0 * Changelog updates: 2nd pass at a clearer changelog. - Fix typos. - Use consistent tense and tone across all changelog. - Remove unclear items. * Changelog: add #7026 * Changelog: add #7058 * Changelog: add #7125 * Changelog: add #7249 * Changelog: add #7185 * add mentions of image widget migration * Changelog: add info about new output for CLI command. * Changelog: add WP version number matching the new Image Widget.
Fixes missing item meta data when syncing WooCommerce tables
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes:
Fixes missing item meta data when syncing WooCommerce tables