SEO Tools: Suppress output if conflicting SEO plugin is active#7249
Merged
dereksmart merged 2 commits intomasterfrom May 29, 2017
Merged
SEO Tools: Suppress output if conflicting SEO plugin is active#7249dereksmart merged 2 commits intomasterfrom
dereksmart merged 2 commits intomasterfrom
Conversation
When SEO plugins like Yoast SEO or All in one SEO are installed on Jetpack site, SEO Tools should stop modifying the meta tags.
jeherve
previously requested changes
May 26, 2017
Member
jeherve
left a comment
There was a problem hiding this comment.
Added a few comments; maybe we can leverage other parts of Jetpack to make our job easier here.
modules/seo-tools.php
Outdated
| ); | ||
|
|
||
| foreach( $jetpack_seo_conflicting_plugins as $seo_pluging ) { | ||
| if ( is_plugin_active( $seo_pluging ) ) { |
Member
There was a problem hiding this comment.
It might be best to use our own get_active_plugins() here, to account for Multisite networks.
| * | ||
| * @module seo-tools | ||
| * | ||
| * @since 4.9.0 |
Member
There was a problem hiding this comment.
Could you change this to 5.0.0, since Jetpack 4.9 is already released?
modules/seo-tools.php
Outdated
| 'all-in-one-seo-pack-pro/all_in_one_seo_pack.php', | ||
| ); | ||
|
|
||
| foreach( $jetpack_seo_conflicting_plugins as $seo_pluging ) { |
Member
There was a problem hiding this comment.
Maybe change seo_pluging into seo_plugin?
| include_once( ABSPATH . 'wp-admin/includes/plugin.php' ); | ||
|
|
||
| // Suppress SEO Tools output if any of the following plugins is active. | ||
| $jetpack_seo_conflicting_plugins = array( |
Member
There was a problem hiding this comment.
Should we extend that list with other SEO plugins? Our existing list of Open Graph conflicting plugins include a few plugins that also add meta tags:
https://github.com/Automattic/jetpack/blob/4.9/class.jetpack.php#L200
Member
Author
There was a problem hiding this comment.
Sure, I don't see any problem with that.
…gle and multisite. Fix version. Fix typo.
eliorivero
approved these changes
May 29, 2017
Contributor
eliorivero
left a comment
There was a problem hiding this comment.
Added a commit using Jetpack::is_plugin_active, fixing version number and typo.
I'll let @vindl to decide whether to update the list of conflicting plugins but so far this is good to go.
Member
Author
|
@eliorivero since we'd have to audit all of the plugins in the list in order to figure out which ones output titles and meta descriptions in addition to |
eliorivero
pushed a commit
that referenced
this pull request
May 30, 2017
* Changelog: first pass at a changelog for 5.0 * Changelog: delete 4.9 testing list. * Changelog: update minimum WP version to match ver. in jetpack.php Fixes #7158 * Changelog: add #6051 * Changelog: add #6753 * Changelog: add #6928 * Changelog: add #6964 * Changelog: add #7014 * Changelog: add #7057 * Changelog: add #7060 * Changelog: add #7068 * Changelog: add #7070 * Changelog: add #7072 * Changelog: add #7071 * Changelog: add release date and post shortlink. * Changelog: add #7094 * Changelog: add #7100 * Changelog: add #7108 * Changelog: add #7113 * Changelog: add #7123 * Changelog: add #7135 * Changelog: add #7143 * Changelog: add #7151 * Changelog: add #6996 * Changelog: add #7105 * Changelog: add #7132 * Changelog: add #7166 * Changelog: fix typo in 4.9 changelog. * Changelog: remove older releases' changelogs. @see p1HpG7-42e-p2 * Changelog: add #7090 * Changelog: add #7095 * Changelog: add #7112 * Changelog: add #7115 * Changelog: add #7122 * Changelog: add #7137 * Changelog: add #7138 * Changelog: add #7140 * Changelog: add #7154 * Changelog: add ##7155 * Changelog: add #7163 * Changelog: add #7167 * Changelog: add #7171 * Changelog: add #7180 * Changelog: add #7181 * Changelog: add #7183 * Changelog: add #7184 * Changelog: add #7189 * Changelog: add #7191 * Changelog: add #7193 * Changelog: add #7198 * Changelog: add #7200 * Changelog: add #7209 * Changelog: add #7212 * Testing list: add instructions for #7115 * Changelog: add #7188 * Changelog: add #7205 * Changelog: add #7225 * Changelog: add #6872 * Changelog: add #7107 * Changelog: add #7118 * Changelog: add #7142 * Changelog: add #7170 * Changelog: add #7210 * Changelog: add #7218 * Changelog: add #7232 * Changelog: add #7211 * Changelog: add #7213 * Changelog: add #7229 * Changelog: add #7230 * Changelog: add #7214 * Draft changelog for 5.0 * Changelog updates: 2nd pass at a clearer changelog. - Fix typos. - Use consistent tense and tone across all changelog. - Remove unclear items. * Changelog: add #7026 * Changelog: add #7058 * Changelog: add #7125 * Changelog: add #7249 * Changelog: add #7185 * add mentions of image widget migration * Changelog: add info about new output for CLI command. * Changelog: add WP version number matching the new Image Widget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SEO plugins like Yoast SEO or All in one SEO are installed on
Jetpack site, SEO Tools should stop modifying the meta tags.
Related PR: Automattic/wp-calypso#14526
Testing instructions:
settings/trafficand adjust some of the SEO settings.