Skip to content

JSON API: replace deprecated method#7118

Merged
eliorivero merged 1 commit intomasterfrom
fix/deprecated-method
May 24, 2017
Merged

JSON API: replace deprecated method#7118
eliorivero merged 1 commit intomasterfrom
fix/deprecated-method

Conversation

@dereksmart
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart commented May 3, 2017

I think the it's stats card is trying to poll roles.

Anyway, this method that's used now has been deprecated since WP 4.7.

To reproduce the error:

[03-May-2017 18:44:02 UTC] PHP Stack trace:
[03-May-2017 18:44:02 UTC] PHP   1. {main}() /home/dereksma/public_html/xmlrpc.php:0
[03-May-2017 18:44:02 UTC] PHP   2. wp_xmlrpc_server->serve_request() /home/dereksma/public_html/xmlrpc.php:84
[03-May-2017 18:44:02 UTC] PHP   3. IXR_Server->IXR_Server() /home/dereksma/public_html/wp-includes/class-wp-xmlrpc-server.php:197
[03-May-2017 18:44:02 UTC] PHP   4. IXR_Server->__construct() /home/dereksma/public_html/wp-includes/IXR/class-IXR-server.php:35
[03-May-2017 18:44:02 UTC] PHP   5. IXR_Server->serve() /home/dereksma/public_html/wp-includes/IXR/class-IXR-server.php:27
[03-May-2017 18:44:02 UTC] PHP   6. IXR_Server->call() /home/dereksma/public_html/wp-includes/IXR/class-IXR-server.php:65
[03-May-2017 18:44:02 UTC] PHP   7. IXR_Server->multiCall() /home/dereksma/public_html/wp-includes/IXR/class-IXR-server.php:115
[03-May-2017 18:44:02 UTC] PHP   8. IXR_Server->call() /home/dereksma/public_html/wp-includes/IXR/class-IXR-server.php:212
[03-May-2017 18:44:02 UTC] PHP   9. Jetpack_XMLRPC_Server->json_api() /home/dereksma/public_html/wp-includes/IXR/class-IXR-server.php:127
[03-May-2017 18:44:02 UTC] PHP  10. WPCOM_JSON_API->serve() /home/dereksma/public_html/wp-content/plugins/jetpack/class.jetpack-xmlrpc-server.php:478
[03-May-2017 18:44:02 UTC] PHP  11. WPCOM_JSON_API->process_request() /home/dereksma/public_html/wp-content/plugins/jetpack/class.json-api.php:316
[03-May-2017 18:44:02 UTC] PHP  12. WPCOM_JSON_API_List_Roles_Endpoint->callback() /home/dereksma/public_html/wp-content/plugins/jetpack/class.json-api.php:332
[03-May-2017 18:44:02 UTC] PHP  13. WP_Roles->reinit() /home/dereksma/public_html/wp-content/plugins/jetpack/json-endpoints/class.wpcom-json-api-list-roles-endpoint.php:49
[03-May-2017 18:44:02 UTC] PHP  14. _deprecated_function() /home/dereksma/public_html/wp-includes/class-wp-roles.php:152
[03-May-2017 18:44:02 UTC] PHP  15. trigger_error() /home/dereksma/public_html/wp-includes/functions.php:3831

@dereksmart dereksmart added [Feature] WPCOM API [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels May 3, 2017
@dereksmart dereksmart force-pushed the fix/deprecated-method branch from 6333294 to a4f978a Compare May 4, 2017 03:17
briancolinger
briancolinger approved these changes May 11, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@briancolinger briancolinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the steps to reproduce and this works for me.

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 17, 2017
@eliorivero eliorivero merged commit 7a88249 into master May 24, 2017
@eliorivero eliorivero deleted the fix/deprecated-method branch May 24, 2017 15:40
@eliorivero eliorivero removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 24, 2017
jeherve added a commit that referenced this pull request May 29, 2017
@jeherve
Changelog: add #7118
4b08b91
eliorivero pushed a commit that referenced this pull request May 30, 2017
@jeherve @eliorivero
Changelog: first pass at a changelog for 5.0 (#7116)
eee27f0 
* Changelog: first pass at a changelog for 5.0

* Changelog: delete 4.9 testing list.

* Changelog: update minimum WP version to match ver. in jetpack.php

Fixes #7158

* Changelog: add #6051

* Changelog: add #6753

* Changelog: add #6928

* Changelog: add #6964

* Changelog: add #7014

* Changelog: add #7057

* Changelog: add #7060

* Changelog: add #7068

* Changelog: add #7070

* Changelog: add #7072

* Changelog: add #7071

* Changelog: add release date and post shortlink.

* Changelog: add #7094

* Changelog: add #7100

* Changelog: add #7108

* Changelog: add #7113

* Changelog: add #7123

* Changelog: add #7135

* Changelog: add #7143

* Changelog: add #7151

* Changelog: add #6996

* Changelog: add #7105

* Changelog: add #7132

* Changelog: add #7166

* Changelog: fix typo in 4.9 changelog.

* Changelog: remove older releases' changelogs.

@see p1HpG7-42e-p2

* Changelog: add #7090

* Changelog: add #7095

* Changelog: add #7112

* Changelog: add #7115

* Changelog: add #7122

* Changelog: add #7137

* Changelog: add #7138

* Changelog: add #7140

* Changelog: add #7154

* Changelog: add ##7155

* Changelog: add #7163

* Changelog: add #7167

* Changelog: add #7171

* Changelog: add #7180

* Changelog: add #7181

* Changelog: add #7183

* Changelog: add #7184

* Changelog: add #7189

* Changelog: add #7191

* Changelog: add #7193

* Changelog: add #7198

* Changelog: add #7200

* Changelog: add #7209

* Changelog: add #7212

* Testing list: add instructions for #7115

* Changelog: add #7188

* Changelog: add #7205

* Changelog: add #7225

* Changelog: add #6872

* Changelog: add #7107

* Changelog: add #7118

* Changelog: add #7142

* Changelog: add #7170

* Changelog: add #7210

* Changelog: add #7218

* Changelog: add #7232

* Changelog: add #7211

* Changelog: add #7213

* Changelog: add #7229

* Changelog: add #7230

* Changelog: add #7214

* Draft changelog for 5.0

* Changelog updates: 2nd pass at a clearer changelog.

- Fix typos.
- Use consistent tense and tone across all changelog.
- Remove unclear items.

* Changelog: add #7026

* Changelog: add #7058

* Changelog: add #7125

* Changelog: add #7249

* Changelog: add #7185

* add mentions of image widget migration

* Changelog: add info about new output for CLI command.

* Changelog: add WP version number matching the new Image Widget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@briancolinger briancolinger briancolinger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug When a feature is broken and / or not performing as intended [Feature] WPCOM API Touches WP.com Files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dereksmart @briancolinger @jeherve @eliorivero @matticbot