Skip to content

Remove Apps card from Jumpstart view#7181

Merged
eliorivero merged 3 commits intomasterfrom
remove/apps-card-jumpstart
May 16, 2017
Merged

Remove Apps card from Jumpstart view#7181
eliorivero merged 3 commits intomasterfrom
remove/apps-card-jumpstart

Conversation

@dereksmart
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart commented May 12, 2017

Reported in p6TEKc-1dr-p2

This removes the apps card from Jumpstart view shown here:
apps-jumpstart

It should still show on all other pages.

To test:

  • Delete the dismiss_dash_app_card option delete_option( 'dismiss_dash_app_card' ) , or start a new site.
  • Click "reset options" in the footer of Jetpack. Or connect a new site.
  • Make sure there's no card on Jumpstart
  • Make sure the card shows on all other pages after jump-starting.

@dereksmart dereksmart added Admin Page React-powered dashboard under the Jetpack menu General [Status] Needs Review This PR is ready for review. labels May 12, 2017
jeherve
jeherve approved these changes May 15, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well, but I was wondering if we should maybe take that opportunity to also hide the banner when the jetpack_show_promotions filter is set to true? (related: #6765)

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 15, 2017
@dereksmart
Copy link
Copy Markdown
Contributor Author

dereksmart commented May 15, 2017

@jeherve Good idea, implemented that in 1dc8187

@jeherve
Copy link
Copy Markdown
Member

jeherve commented May 16, 2017

@dereksmart The card remains on the dashboard page when I set add_filter( 'jetpack_show_promotions', '__return_false' );. Does it work for you?

@dereksmart
Copy link
Copy Markdown
Contributor Author

dereksmart commented May 16, 2017

@jeherve thanks for testing -- the conditional was backwards :lookaround:

Should be working as expected now

jeherve
jeherve approved these changes May 16, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well now! 🚢

@eliorivero
Copy link
Copy Markdown
Contributor

eliorivero commented May 16, 2017

LGTM 🐑

@eliorivero eliorivero merged commit ca0ea6c into master May 16, 2017
@eliorivero eliorivero deleted the remove/apps-card-jumpstart branch May 16, 2017 13:09
@eliorivero eliorivero removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 16, 2017
jeherve added a commit that referenced this pull request May 23, 2017
@jeherve
Changelog: add #7181
f0ab07d
jeherve added a commit that referenced this pull request May 29, 2017
@jeherve
Changelog: add #7181
a95f576
eliorivero pushed a commit that referenced this pull request May 30, 2017
@jeherve @eliorivero
Changelog: first pass at a changelog for 5.0 (#7116)
eee27f0 
* Changelog: first pass at a changelog for 5.0

* Changelog: delete 4.9 testing list.

* Changelog: update minimum WP version to match ver. in jetpack.php

Fixes #7158

* Changelog: add #6051

* Changelog: add #6753

* Changelog: add #6928

* Changelog: add #6964

* Changelog: add #7014

* Changelog: add #7057

* Changelog: add #7060

* Changelog: add #7068

* Changelog: add #7070

* Changelog: add #7072

* Changelog: add #7071

* Changelog: add release date and post shortlink.

* Changelog: add #7094

* Changelog: add #7100

* Changelog: add #7108

* Changelog: add #7113

* Changelog: add #7123

* Changelog: add #7135

* Changelog: add #7143

* Changelog: add #7151

* Changelog: add #6996

* Changelog: add #7105

* Changelog: add #7132

* Changelog: add #7166

* Changelog: fix typo in 4.9 changelog.

* Changelog: remove older releases' changelogs.

@see p1HpG7-42e-p2

* Changelog: add #7090

* Changelog: add #7095

* Changelog: add #7112

* Changelog: add #7115

* Changelog: add #7122

* Changelog: add #7137

* Changelog: add #7138

* Changelog: add #7140

* Changelog: add #7154

* Changelog: add ##7155

* Changelog: add #7163

* Changelog: add #7167

* Changelog: add #7171

* Changelog: add #7180

* Changelog: add #7181

* Changelog: add #7183

* Changelog: add #7184

* Changelog: add #7189

* Changelog: add #7191

* Changelog: add #7193

* Changelog: add #7198

* Changelog: add #7200

* Changelog: add #7209

* Changelog: add #7212

* Testing list: add instructions for #7115

* Changelog: add #7188

* Changelog: add #7205

* Changelog: add #7225

* Changelog: add #6872

* Changelog: add #7107

* Changelog: add #7118

* Changelog: add #7142

* Changelog: add #7170

* Changelog: add #7210

* Changelog: add #7218

* Changelog: add #7232

* Changelog: add #7211

* Changelog: add #7213

* Changelog: add #7229

* Changelog: add #7230

* Changelog: add #7214

* Draft changelog for 5.0

* Changelog updates: 2nd pass at a clearer changelog.

- Fix typos.
- Use consistent tense and tone across all changelog.
- Remove unclear items.

* Changelog: add #7026

* Changelog: add #7058

* Changelog: add #7125

* Changelog: add #7249

* Changelog: add #7185

* add mentions of image widget migration

* Changelog: add info about new output for CLI command.

* Changelog: add WP version number matching the new Image Widget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

No one assigned

Labels

Admin Page React-powered dashboard under the Jetpack menu General

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dereksmart @jeherve @eliorivero